Merge PR #481 into 16.0

Signed-off-by pedrobaeza

document_page_approval/models/document_page_history.py

@@ -78,7 +78,7 @@ class DocumentPageHistory(models.Model):
                 users = self.env["res.users"].search(
                     [("groups_id", "in", guids), ("groups_id", "in", approver_gid.id)]
                 )
-                rec.message_subscribe([u.id for u in users])
+                rec.message_subscribe(partner_ids=users.mapped("partner_id").ids)
                 rec.message_post_with_template(template.id)
             else:
                 # auto-approve if approval is not required

document_page_approval/readme/CONTRIBUTORS.rst

@@ -3,7 +3,11 @@
 * Gervais Naoussi <gervaisnaoussi@gmail.com>
 * Maxime Chambreuil <mchambreuil@opensourceintegrators.com>
 * Iván Todorovich <ivan.todorovich@gmail.com>
-* Victor M.M. Torres <victor.martin@tecnativa.com>
+
+* `Tecnativa <https://www.tecnativa.com>`_:
+
+    * Victor M.M. Torres
+    * Víctor Martínez
 
 * `Guadaltech <https://www.guadaltech.es>`_:
 

document_page_approval/tests/test_document_page_approval.py

@@ -13,6 +13,18 @@ class TestDocumentPageApproval(common.TransactionCase):
             "document_page_approval.group_document_approver_user"
         )
         self.env.ref("base.user_root").write({"groups_id": [(4, self.approver_gid.id)]})
+        self.env.ref("base.user_admin").write(
+            {"groups_id": [(4, self.approver_gid.id)]}
+        )
+        self.user2 = self.env["res.users"].create(
+            {
+                "name": "Test user 2",
+                "login": "Test user 2",
+                "groups_id": [
+                    (6, 0, [self.env.ref("base.group_user").id, self.approver_gid.id])
+                ],
+            }
+        )
         # demo_approval
         self.category2 = self.page_obj.create(
             {
@@ -44,6 +56,9 @@ class TestDocumentPageApproval(common.TransactionCase):
 
         # It should automatically be in 'to approve' state
         self.assertEqual(chreq.state, "to approve")
+        user_admin = self.env.ref("base.user_admin")
+        self.assertTrue(user_admin.partner_id.id in chreq.message_partner_ids.ids)
+        self.assertTrue(self.user2.partner_id.id in chreq.message_partner_ids.ids)
 
         # Needed to compute calculated fields
         page.invalidate_model()