diff --git a/document_page_approval/models/document_page_history.py b/document_page_approval/models/document_page_history.py index 7502047e..905e6f0b 100644 --- a/document_page_approval/models/document_page_history.py +++ b/document_page_approval/models/document_page_history.py @@ -78,7 +78,7 @@ class DocumentPageHistory(models.Model): users = self.env["res.users"].search( [("groups_id", "in", guids), ("groups_id", "in", approver_gid.id)] ) - rec.message_subscribe([u.id for u in users]) + rec.message_subscribe(partner_ids=users.mapped("partner_id").ids) rec.message_post_with_template(template.id) else: # auto-approve if approval is not required diff --git a/document_page_approval/readme/CONTRIBUTORS.rst b/document_page_approval/readme/CONTRIBUTORS.rst index f2a999f9..a06acbda 100644 --- a/document_page_approval/readme/CONTRIBUTORS.rst +++ b/document_page_approval/readme/CONTRIBUTORS.rst @@ -3,7 +3,11 @@ * Gervais Naoussi * Maxime Chambreuil * Iván Todorovich -* Victor M.M. Torres + +* `Tecnativa `_: + + * Victor M.M. Torres + * Víctor Martínez * `Guadaltech `_: diff --git a/document_page_approval/tests/test_document_page_approval.py b/document_page_approval/tests/test_document_page_approval.py index ac0f3c62..e9154ade 100644 --- a/document_page_approval/tests/test_document_page_approval.py +++ b/document_page_approval/tests/test_document_page_approval.py @@ -13,6 +13,18 @@ class TestDocumentPageApproval(common.TransactionCase): "document_page_approval.group_document_approver_user" ) self.env.ref("base.user_root").write({"groups_id": [(4, self.approver_gid.id)]}) + self.env.ref("base.user_admin").write( + {"groups_id": [(4, self.approver_gid.id)]} + ) + self.user2 = self.env["res.users"].create( + { + "name": "Test user 2", + "login": "Test user 2", + "groups_id": [ + (6, 0, [self.env.ref("base.group_user").id, self.approver_gid.id]) + ], + } + ) # demo_approval self.category2 = self.page_obj.create( { @@ -44,6 +56,9 @@ class TestDocumentPageApproval(common.TransactionCase): # It should automatically be in 'to approve' state self.assertEqual(chreq.state, "to approve") + user_admin = self.env.ref("base.user_admin") + self.assertTrue(user_admin.partner_id.id in chreq.message_partner_ids.ids) + self.assertTrue(self.user2.partner_id.id in chreq.message_partner_ids.ids) # Needed to compute calculated fields page.invalidate_model()