netbox/netbox
Jeremy Stretch 63a167f130
Fixes #15924: Fix API interface patch tagged all mode (#18759)
* Fixes: #15924 - Prevent API payload from allowing tagged_vlans while interface mode is set to taged-all

* Prevent cleanup of tagged_vlans when no tagged_vlans set on interface

* Fix test errors

* Remove accidental debug statements

* Update validation to model clean method instead of serializer

* Remove clearing of tagged vlans from `save()`

* Make changes to validation to account for M2M not being available under model in addition to not being able to check incoming vlans under same model.

* Optimize untagged vlan check

* Re-ordering statements in validators

* Forgot to call super().clean()

* Adjust logic for form and serializer.  Add tests

* Fix test failure

* Fix ruff errors

* Fix test by removing now invalid test

* Update serializer, form and tests

* Optimize API test for vlan fields

* Optimize API serializer logic

---------

Co-authored-by: Daniel Sheppard <dans@dansheps.com>
2025-02-28 11:01:48 -05:00
..
account Merge branch 'develop' into feature 2024-08-14 10:54:31 -04:00
circuits Fixes #18758: Enable sorting by Account count on prodiver list (#18763) 2025-02-28 07:28:09 -08:00
core Fix definition of vid_ranges in VLANGroup so it shows up in the OpenAPI schema (#18237) 2025-02-25 16:34:15 -08:00
dcim Fixes #15924: Fix API interface patch tagged all mode (#18759) 2025-02-28 11:01:48 -05:00
extras Fixes: #17796 Custom Field Choices -> Create & Add Another causes IndexError (#18631) 2025-02-25 14:44:10 -08:00
ipam Fixes #18605: only VLANs at selected Site are shown in VLAN select 2025-02-24 11:29:31 -06:00
media
netbox Do not retrieve the data field from Job objects unless needed 2025-02-24 09:07:16 -06:00
project-static Release v4.2.4 2025-02-21 15:15:14 -05:00
reports
scripts
templates Fixes 18208: Consolidate rendering configuration templates (#18604) 2025-02-10 11:03:08 -05:00
tenancy Closes #17752: Rename URL paths for bulk import to *_bulk_import 2024-11-22 12:51:06 -05:00
translations Update source translation strings 2025-02-26 05:02:07 +00:00
users Closes #17752: Rename URL paths for bulk import to *_bulk_import 2024-11-22 12:51:06 -05:00
utilities Fixes #18141: Fix quick-add support for plugin models 2025-02-26 14:25:38 -05:00
virtualization Add VLAN Translation Policy to bulk edit forms and tables for Interface and VMInterface 2025-02-24 13:55:40 -05:00
vpn fix contact wrong model assignment 2025-02-25 13:53:50 +01:00
wireless Make GFK scope field sortable=False on tables where it appears 2025-01-17 08:52:12 -05:00
generate_secret_key.py Change Interpreter in shebang to python3 2023-02-27 14:09:10 -05:00
manage.py Fix ambiguous shebang in netbox/manage.py. 2024-10-24 09:04:49 -04:00
release.yaml Release v4.2.4 2025-02-21 15:15:14 -05:00