NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-12-12 11:29:36 -06:00
Code Issues Actions 13 Packages Projects Releases Wiki Activity

Removed explicit checks against QueryField and [Null]BooleanField

Browse Source 
I did add them to FORM_FIELD_LOOKUPS, though, to underscore that they
were considered and are intentially empty for future devs.
This commit is contained in:
Jason Novinger 2025-11-24 15:35:24 -06:00
parent 860bdae1e9
commit edbcea817c
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
netbox/utilities/forms/mixins.py
View File

@ -21,6 +21,9 @@ __all__ = (
# Mapping of form field types to their supported lookups # Mapping of form field types to their supported lookups
FORM_FIELD_LOOKUPS = { FORM_FIELD_LOOKUPS = {
QueryField: [],
forms.BooleanField: [],
forms.NullBooleanField: [],
forms.CharField: [ forms.CharField: [
('exact', _('Is')), ('exact', _('Is')),
('n', _('Is Not')), ('n', _('Is Not')),
@ -204,12 +207,6 @@ class FilterModifierMixin:
Returns an empty list for fields that should not be enhanced. Returns an empty list for fields that should not be enhanced.
""" """
if isinstance(field, QueryField):
return []
if isinstance(field, (forms.BooleanField, forms.NullBooleanField)):
return []
for field_class in field.__class__.__mro__: for field_class in field.__class__.__mro__:
if field_class in FORM_FIELD_LOOKUPS: if field_class in FORM_FIELD_LOOKUPS:
return FORM_FIELD_LOOKUPS[field_class] return FORM_FIELD_LOOKUPS[field_class]