From edbcea817cee9ae81e74a7aa8fa3afb7b93b7b9c Mon Sep 17 00:00:00 2001 From: Jason Novinger Date: Mon, 24 Nov 2025 15:35:24 -0600 Subject: [PATCH] Removed explicit checks against QueryField and [Null]BooleanField I did add them to FORM_FIELD_LOOKUPS, though, to underscore that they were considered and are intentially empty for future devs. --- netbox/utilities/forms/mixins.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/netbox/utilities/forms/mixins.py b/netbox/utilities/forms/mixins.py index 5d0828a06..31264aeda 100644 --- a/netbox/utilities/forms/mixins.py +++ b/netbox/utilities/forms/mixins.py @@ -21,6 +21,9 @@ __all__ = ( # Mapping of form field types to their supported lookups FORM_FIELD_LOOKUPS = { + QueryField: [], + forms.BooleanField: [], + forms.NullBooleanField: [], forms.CharField: [ ('exact', _('Is')), ('n', _('Is Not')), @@ -204,12 +207,6 @@ class FilterModifierMixin: Returns an empty list for fields that should not be enhanced. """ - if isinstance(field, QueryField): - return [] - - if isinstance(field, (forms.BooleanField, forms.NullBooleanField)): - return [] - for field_class in field.__class__.__mro__: if field_class in FORM_FIELD_LOOKUPS: return FORM_FIELD_LOOKUPS[field_class]