NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-02-04 06:16:23 -06:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixes #18619: shift-select selects hidden items

Browse Source 
This also fixes the inverse, when a range is unselected via shift-click,
previously checked checkboxes that are hidden are not changed.
This commit is contained in:
Jason Novinger
2025-02-18 10:03:49 -06:00
committed by Jeremy Stretch
parent b5bc0bad38
commit ed79e3bbf4
3 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
netbox/project-static/dist/netbox.js
Vendored
+1 -1
View File
File diff suppressed because one or more lines are too long
netbox/project-static/dist/netbox.js.map
Vendored
+2 -2
View File
File diff suppressed because one or more lines are too long
netbox/project-static/src/buttons/selectMultiple.ts
+6 -2
View File
@@ -43,7 +43,9 @@ function toggleCheckboxRange(
const typedElement = element as HTMLInputElement; const typedElement = element as HTMLInputElement;
//Change loop's current checkbox state to eventTargetElement checkbox state //Change loop's current checkbox state to eventTargetElement checkbox state
if (changePkCheckboxState === true) { if (changePkCheckboxState === true) {
typedElement.checked = eventTargetElement.checked; if (!typedElement.closest('tr')?.classList.contains('d-none')) {
typedElement.checked = eventTargetElement.checked;
}
} }
//The previously clicked checkbox was above the shift clicked checkbox //The previously clicked checkbox was above the shift clicked checkbox
if (element === previousStateElement) { if (element === previousStateElement) {
@@ -52,7 +54,9 @@ function toggleCheckboxRange(
return; return;
} }
changePkCheckboxState = true; changePkCheckboxState = true;
typedElement.checked = eventTargetElement.checked; if (!typedElement.closest('tr')?.classList.contains('d-none')) {
typedElement.checked = eventTargetElement.checked;
}
} }
//The previously clicked checkbox was below the shift clicked checkbox //The previously clicked checkbox was below the shift clicked checkbox
if (element === eventTargetElement) { if (element === eventTargetElement) {