From ed79e3bbf4617ec0764c6e7bd1f289d7abb22106 Mon Sep 17 00:00:00 2001 From: Jason Novinger Date: Tue, 18 Feb 2025 10:03:49 -0600 Subject: [PATCH] Fixes #18619: shift-select selects hidden items This also fixes the inverse, when a range is unselected via shift-click, previously checked checkboxes that are hidden are not changed. --- netbox/project-static/dist/netbox.js | Bin 391058 -> 391196 bytes netbox/project-static/dist/netbox.js.map | Bin 525511 -> 525648 bytes .../src/buttons/selectMultiple.ts | 8 ++++++-- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/netbox/project-static/dist/netbox.js b/netbox/project-static/dist/netbox.js index 7e516f7f4859ffcafee6698af56ca52c89acb58c..bb402ec3321ec44f949a3f8bf9b7518cd03ead91 100644 GIT binary patch delta 249 zcmbRAUVP36@rD-07N#xC@$J!NiA4%UnL7EI);Xyq3VE5fiiXx{`9&HaUU8;Eewso_ zre-yWmzZf=oN1kzrU6uBYpZCWrlz4$lxdrosh6CSUz}Q8qM=k$q@<~-Xq#7>lcT0q zH2uIqCNa$v-Msv~R3*)t8V!)rjMU`p)D+uHI8#$orx;{l>huro%!=|l8u@t4%mW+scnAYI$%3LOH^%(4msr38V1z8en_cvL36}NcUjOUG0O}j;F+Ll01Bl4L+uuS zp|ivy delta 357 zcmcc6rEt7cp`nGbg{g&k3(K>7CTG9tzw=pS6Ww&&9UT*OoE@FBoOL`M9ev$F0;w)Q z(znP7NP2m?=y*Fi8aM$-XHzFvi26WB$It)}GuKHc*wMYh*%zcJ(gP$^>;y8dz!}8$ zbe+DjfW^SU-O;%Mn_hpQna)7vu8v^U5L5g>?0m2(IS^C4!KO^_EM!q*44S^7kVS$w z7^KKo2WWt?li&2Kg)9zYfe@i!N9PcrxF^VKZjMpYwToD64ZzA%!KPU_>Et>CUGA*o z>gZhJ76P#i91!_VVDA?@`A?rw#8Si;1(5?PbS-d-oGww!V!>$G9$3r*#H>Kfwmq;SMEXygC@ diff --git a/netbox/project-static/src/buttons/selectMultiple.ts b/netbox/project-static/src/buttons/selectMultiple.ts index d8bad3105..5695b6c24 100644 --- a/netbox/project-static/src/buttons/selectMultiple.ts +++ b/netbox/project-static/src/buttons/selectMultiple.ts @@ -43,7 +43,9 @@ function toggleCheckboxRange( const typedElement = element as HTMLInputElement; //Change loop's current checkbox state to eventTargetElement checkbox state if (changePkCheckboxState === true) { - typedElement.checked = eventTargetElement.checked; + if (!typedElement.closest('tr')?.classList.contains('d-none')) { + typedElement.checked = eventTargetElement.checked; + } } //The previously clicked checkbox was above the shift clicked checkbox if (element === previousStateElement) { @@ -52,7 +54,9 @@ function toggleCheckboxRange( return; } changePkCheckboxState = true; - typedElement.checked = eventTargetElement.checked; + if (!typedElement.closest('tr')?.classList.contains('d-none')) { + typedElement.checked = eventTargetElement.checked; + } } //The previously clicked checkbox was below the shift clicked checkbox if (element === eventTargetElement) {