mirror of
https://github.com/netbox-community/netbox.git
synced 2026-01-09 13:22:18 -06:00
Address PR feedback
This commit is contained in:
@@ -2682,6 +2682,7 @@ class DeviceConfigContextView(ObjectConfigContextView):
|
|||||||
class DeviceRenderConfigView(ObjectRenderConfigView):
|
class DeviceRenderConfigView(ObjectRenderConfigView):
|
||||||
queryset = Device.objects.all()
|
queryset = Device.objects.all()
|
||||||
base_template = 'dcim/device/base.html'
|
base_template = 'dcim/device/base.html'
|
||||||
|
additional_permissions = ['dcim.render_config_device']
|
||||||
tab = ViewTab(
|
tab = ViewTab(
|
||||||
label=_('Render Config'),
|
label=_('Render Config'),
|
||||||
weight=2100,
|
weight=2100,
|
||||||
|
|||||||
@@ -27,7 +27,6 @@ from netbox.views.generic.mixins import TableMixin
|
|||||||
from utilities.forms import ConfirmationForm, get_field_value
|
from utilities.forms import ConfirmationForm, get_field_value
|
||||||
from utilities.htmx import htmx_partial, htmx_maybe_redirect_current_page
|
from utilities.htmx import htmx_partial, htmx_maybe_redirect_current_page
|
||||||
from utilities.paginator import EnhancedPaginator, get_paginate_count
|
from utilities.paginator import EnhancedPaginator, get_paginate_count
|
||||||
from utilities.permissions import get_permission_for_model
|
|
||||||
from utilities.query import count_related
|
from utilities.query import count_related
|
||||||
from utilities.querydict import normalize_querydict
|
from utilities.querydict import normalize_querydict
|
||||||
from utilities.request import copy_safe_request
|
from utilities.request import copy_safe_request
|
||||||
@@ -1083,14 +1082,6 @@ class ObjectRenderConfigView(generic.ObjectView):
|
|||||||
base_template = None
|
base_template = None
|
||||||
template_name = 'extras/object_render_config.html'
|
template_name = 'extras/object_render_config.html'
|
||||||
|
|
||||||
def has_permission(self):
|
|
||||||
if super().has_permission(): # enforce base required permission
|
|
||||||
perm = get_permission_for_model(self.queryset.model, 'render_config')
|
|
||||||
if self.request.user.has_perm(perm):
|
|
||||||
self.queryset = self.queryset.restrict(self.request.user, 'render_config')
|
|
||||||
return True
|
|
||||||
return False
|
|
||||||
|
|
||||||
def get(self, request, **kwargs):
|
def get(self, request, **kwargs):
|
||||||
instance = self.get_object(**kwargs)
|
instance = self.get_object(**kwargs)
|
||||||
context = self.get_extra_context(request, instance)
|
context = self.get_extra_context(request, instance)
|
||||||
|
|||||||
@@ -405,6 +405,7 @@ class VirtualMachineConfigContextView(ObjectConfigContextView):
|
|||||||
class VirtualMachineRenderConfigView(ObjectRenderConfigView):
|
class VirtualMachineRenderConfigView(ObjectRenderConfigView):
|
||||||
queryset = VirtualMachine.objects.all()
|
queryset = VirtualMachine.objects.all()
|
||||||
base_template = 'virtualization/virtualmachine/base.html'
|
base_template = 'virtualization/virtualmachine/base.html'
|
||||||
|
additional_permissions = ['virtualization.render_config_virtualmachine']
|
||||||
tab = ViewTab(
|
tab = ViewTab(
|
||||||
label=_('Render Config'),
|
label=_('Render Config'),
|
||||||
weight=2100,
|
weight=2100,
|
||||||
|
|||||||
Reference in New Issue
Block a user