From 68ec84ff70b33ba5e573a9d3f38e14d602c11a3b Mon Sep 17 00:00:00 2001
From: Jason Novinger <jnovinger@gmail.com>
Date: Mon, 15 Dec 2025 15:08:19 -0600
Subject: [PATCH] Address PR feedback

---
 netbox/dcim/views.py           | 1 +
 netbox/extras/views.py         | 9 ---------
 netbox/virtualization/views.py | 1 +
 3 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/netbox/dcim/views.py b/netbox/dcim/views.py
index c6d9a889f..ba9365c83 100644
--- a/netbox/dcim/views.py
+++ b/netbox/dcim/views.py
@@ -2682,6 +2682,7 @@ class DeviceConfigContextView(ObjectConfigContextView):
 class DeviceRenderConfigView(ObjectRenderConfigView):
     queryset = Device.objects.all()
     base_template = 'dcim/device/base.html'
+    additional_permissions = ['dcim.render_config_device']
     tab = ViewTab(
         label=_('Render Config'),
         weight=2100,
diff --git a/netbox/extras/views.py b/netbox/extras/views.py
index 34b2f0a47..3c1fc395d 100644
--- a/netbox/extras/views.py
+++ b/netbox/extras/views.py
@@ -27,7 +27,6 @@ from netbox.views.generic.mixins import TableMixin
 from utilities.forms import ConfirmationForm, get_field_value
 from utilities.htmx import htmx_partial, htmx_maybe_redirect_current_page
 from utilities.paginator import EnhancedPaginator, get_paginate_count
-from utilities.permissions import get_permission_for_model
 from utilities.query import count_related
 from utilities.querydict import normalize_querydict
 from utilities.request import copy_safe_request
@@ -1083,14 +1082,6 @@ class ObjectRenderConfigView(generic.ObjectView):
     base_template = None
     template_name = 'extras/object_render_config.html'
 
-    def has_permission(self):
-        if super().has_permission():  # enforce base required permission
-            perm = get_permission_for_model(self.queryset.model, 'render_config')
-            if self.request.user.has_perm(perm):
-                self.queryset = self.queryset.restrict(self.request.user, 'render_config')
-                return True
-        return False
-
     def get(self, request, **kwargs):
         instance = self.get_object(**kwargs)
         context = self.get_extra_context(request, instance)
diff --git a/netbox/virtualization/views.py b/netbox/virtualization/views.py
index a7aa80f10..b7aca4d73 100644
--- a/netbox/virtualization/views.py
+++ b/netbox/virtualization/views.py
@@ -405,6 +405,7 @@ class VirtualMachineConfigContextView(ObjectConfigContextView):
 class VirtualMachineRenderConfigView(ObjectRenderConfigView):
     queryset = VirtualMachine.objects.all()
     base_template = 'virtualization/virtualmachine/base.html'
+    additional_permissions = ['virtualization.render_config_virtualmachine']
     tab = ViewTab(
         label=_('Render Config'),
         weight=2100,