NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-08-24 16:26:09 -06:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

11508 review changes, change SOCIAL_AUTH_ to REMOTE_AUTH_BACKEND

Browse Source
This commit is contained in:
Arthur 2023-08-08 16:51:44 +07:00
parent 7e017c938a
commit 605f232cc2
3 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/administration/authentication/microsoft-azure-ad.md
View File

@ -82,20 +82,20 @@ SOCIAL_AUTH_PIPELINE = (
) )
# Define special user types using groups. Exercise great caution when assigning superuser status. # Define special user types using groups. Exercise great caution when assigning superuser status.
SOCIAL_AUTH_AZUREAD_USER_FLAGS_BY_GROUP = { REMOTE_AUTH_BACKEND_AZUREAD_USER_FLAGS_BY_GROUP = {
"is_staff": ['{AZURE_GROUP_ID}',], "is_staff": ['{AZURE_GROUP_ID}',],
"is_superuser": ['{AZURE_GROUP_ID}',] "is_superuser": ['{AZURE_GROUP_ID}',]
} }
SOCIAL_AUTH_AZUREAD_GROUP_MAP = { REMOTE_AUTH_BACKEND_AZUREAD_GROUP_MAP = {
'{AZURE_GROUP_ID}': '{NETBOX_GROUP}', '{AZURE_GROUP_ID}': '{NETBOX_GROUP}',
} }
``` ```
**SOCIAL_AUTH_AZUREAD_USER_FLAGS_BY_GROUP.is_staff**: users who are in any of the Azure AD group-ids in the array will have staff permission assigned to them. **REMOTE_AUTH_BACKEND_AZUREAD_USER_FLAGS_BY_GROUP.is_staff**: users who are in any of the Azure AD group-ids in the array will have staff permission assigned to them.
**SOCIAL_AUTH_AZUREAD_USER_FLAGS_BY_GROUP.is_superuser**: users who are in any of the Azure AD group-ids in the array will have superuser permission assigned to them. **REMOTE_AUTH_BACKEND_AZUREAD_USER_FLAGS_BY_GROUP.is_superuser**: users who are in any of the Azure AD group-ids in the array will have superuser permission assigned to them.
**SOCIAL_AUTH_AZUREAD_GROUP_MAP**: Any user with the given Azure AD group-id is included in the given NetBox group name. **REMOTE_AUTH_BACKEND_AZUREAD_GROUP_MAP**: Any user with the given Azure AD group-id is included in the given NetBox group name.
## Testing ## Testing

12
netbox/netbox/authentication.py
View File

@ -398,18 +398,18 @@ def azuread_map_groups(response, user, backend, *args, **kwargs):
''' '''
logger = logging.getLogger('netbox.auth.azuread_map_groups') logger = logging.getLogger('netbox.auth.azuread_map_groups')
if not hasattr(settings, "SOCIAL_AUTH_AZUREAD_USER_FLAGS_BY_GROUP"): if not hasattr(settings, "REMOTE_AUTH_BACKEND_AZUREAD_USER_FLAGS_BY_GROUP"):
raise ImproperlyConfigured( raise ImproperlyConfigured(
"Azure group mapping has been configured, but SOCIAL_AUTH_AZUREAD_USER_FLAGS_BY_GROUP is not defined." "Azure group mapping has been configured, but REMOTE_AUTH_BACKEND_AZUREAD_USER_FLAGS_BY_GROUP is not defined."
) )
if not hasattr(settings, "SOCIAL_AUTH_AZUREAD_GROUP_MAP"): if not hasattr(settings, "REMOTE_AUTH_BACKEND_AZUREAD_GROUP_MAP"):
raise ImproperlyConfigured( raise ImproperlyConfigured(
"Azure group mapping has been configured, but SOCIAL_AUTH_AZUREAD_GROUP_MAP is not defined." "Azure group mapping has been configured, but REMOTE_AUTH_BACKEND_AZUREAD_GROUP_MAP is not defined."
) )
flags_by_group = getattr(settings, "SOCIAL_AUTH_AZUREAD_USER_FLAGS_BY_GROUP") flags_by_group = getattr(settings, "REMOTE_AUTH_BACKEND_AZUREAD_USER_FLAGS_BY_GROUP")
group_mapping = getattr(settings, "SOCIAL_AUTH_AZUREAD_GROUP_MAP") group_mapping = getattr(settings, "REMOTE_AUTH_BACKEND_AZUREAD_GROUP_MAP")
access_token = response.get('access_token') access_token = response.get('access_token')
headers = { headers = {

5
netbox/netbox/settings.py
View File

@ -162,6 +162,11 @@ TIME_FORMAT = getattr(configuration, 'TIME_FORMAT', 'g:i a')
TIME_ZONE = getattr(configuration, 'TIME_ZONE', 'UTC') TIME_ZONE = getattr(configuration, 'TIME_ZONE', 'UTC')
ENABLE_LOCALIZATION = getattr(configuration, 'ENABLE_LOCALIZATION', False) ENABLE_LOCALIZATION = getattr(configuration, 'ENABLE_LOCALIZATION', False)
# Load all REMOTE_AUTH_BACKEND_* settings from the user configuration
for param in dir(configuration):
if param.startswith('REMOTE_AUTH_BACKEND_'):
globals()[param] = getattr(configuration, param)
# Check for hard-coded dynamic config parameters # Check for hard-coded dynamic config parameters
for param in PARAMS: for param in PARAMS:
if hasattr(configuration, param.name): if hasattr(configuration, param.name):