11508 review changes, remove extra flag

docs/administration/authentication/microsoft-azure-ad.md

@@ -80,7 +80,6 @@ SOCIAL_AUTH_PIPELINE = (
     'social_core.pipeline.user.user_details',
     'netbox.authentication.azuread_map_groups',
 )
-SOCIAL_AUTH_AZUREAD_MAP_GROUP_PERMS = True
 
 # Define special user types using groups. Exercise great caution when assigning superuser status.
 SOCIAL_AUTH_AZUREAD_USER_FLAGS_BY_GROUP = {

netbox/netbox/authentication.py

@@ -397,8 +397,6 @@ def azuread_map_groups(response, user, backend, *args, **kwargs):
     Also set is_superuser or is_staff based on config map
     '''
     logger = logging.getLogger('netbox.auth.azuread_map_groups')
-    if not getattr(settings, "SOCIAL_AUTH_AZUREAD_MAP_GROUP_PERMS", False):
-        return
 
     if not hasattr(settings, "SOCIAL_AUTH_AZUREAD_USER_FLAGS_BY_GROUP"):
         raise ImproperlyConfigured(