🔀 Merge pull request #165 from TheNetworkGuy/remove-pylint-annotations

💡 Removed old pylint annotations

modules/device.py

@@ -1,4 +1,3 @@
-# pylint: disable=invalid-name, logging-not-lazy, too-many-locals, logging-fstring-interpolation, too-many-lines, too-many-public-methods, duplicate-code
 """
 Device specific handeling for NetBox to Zabbix
 """
@@ -34,7 +33,6 @@ config = load_config()
 
 
 class PhysicalDevice:
-    # pylint: disable=too-many-instance-attributes, too-many-arguments, too-many-positional-arguments
     """
     Represents Network device.
     INPUT: (NetBox device class, ZabbixAPI class, journal flag, NB journal class)
@@ -657,7 +655,6 @@ class PhysicalDevice:
     def consistency_check(
         self, groups, templates, proxies, proxy_power, create_hostgroups
     ):
-        # pylint: disable=too-many-branches, too-many-statements
         """
         Checks if Zabbix object is still valid with NetBox parameters.
         """
@@ -878,7 +875,6 @@ class PhysicalDevice:
                 self.update_zabbix_host(tags=self.tags)
 
         # If only 1 interface has been found
-        # pylint: disable=too-many-nested-blocks
         if len(host["interfaces"]) == 1:
             updates = {}
             # Go through each key / item and check if it matches Zabbix

modules/hostgroups.py

@@ -10,8 +10,6 @@ class Hostgroup:
     """Hostgroup class for devices and VM's
     Takes type (vm or dev) and NB object"""
 
-    # pylint: disable=too-many-arguments, disable=too-many-positional-arguments
-    # pylint: disable=logging-fstring-interpolation
     def __init__(
         self,
         obj_type,

modules/interface.py

@@ -40,7 +40,6 @@ class ZabbixInterface:
 
     def set_snmp(self):
         """Check if interface is type SNMP"""
-        # pylint: disable=too-many-branches
         snmp_interface_type = 2
         if self.interface["type"] == snmp_interface_type:
             # Checks if SNMP settings are defined in NetBox

modules/tags.py

@@ -1,4 +1,3 @@
-# pylint: disable=too-many-instance-attributes, too-many-arguments, too-many-positional-arguments, logging-fstring-interpolation
 """
 All of the Zabbix Usermacro related configuration
 """
@@ -101,7 +100,6 @@ class ZabbixTags:
         """
         Generate full set of Usermacros
         """
-        # pylint: disable=too-many-branches
         tags = []
         # Parse the field mapper for tags
         if self.tag_map:

modules/usermacros.py

@@ -1,4 +1,3 @@
-# pylint: disable=too-many-instance-attributes, too-many-arguments, too-many-positional-arguments, logging-fstring-interpolation
 """
 All of the Zabbix Usermacro related configuration
 """

modules/virtual_machine.py

@@ -1,4 +1,3 @@
-# pylint: disable=duplicate-code
 """Module that hosts all functions for virtual machine processing"""
 
 from modules.config import load_config

netbox_zabbix_sync.py

@@ -1,5 +1,4 @@
 #!/usr/bin/env python3
-# pylint: disable=invalid-name, logging-not-lazy, too-many-locals, logging-fstring-interpolation
 
 """NetBox to Zabbix sync script."""
 
@@ -30,7 +29,6 @@ logger = get_logger()
 
 def main(arguments):
     """Run the sync process."""
-    # pylint: disable=too-many-branches, too-many-statements
     # set environment variables
     if arguments.verbose:
         set_log_levels(logging.WARNING, logging.INFO)

tests/test_device_deletion.py

@@ -111,7 +111,7 @@ class TestDeviceDeletion(unittest.TestCase):
     def test_zeroize_cf(self):
         """Test _zeroize_cf method that clears the custom field."""
         # Execute
-        self.device._zeroize_cf()  #  pylint: disable=protected-access
+        self.device._zeroize_cf()
 
         # Verify
         self.assertIsNone(self.mock_nb_device.custom_fields["zabbix_hostid"])

tests/test_interface.py

@@ -91,27 +91,27 @@ class TestZabbixInterface(unittest.TestCase):
 
         # Test for agent type (1)
         interface.interface["type"] = 1
-        interface._set_default_port()  #  pylint: disable=protected-access
+        interface._set_default_port()
         self.assertEqual(interface.interface["port"], "10050")
 
         # Test for SNMP type (2)
         interface.interface["type"] = 2
-        interface._set_default_port()  #  pylint: disable=protected-access
+        interface._set_default_port()
         self.assertEqual(interface.interface["port"], "161")
 
         # Test for IPMI type (3)
         interface.interface["type"] = 3
-        interface._set_default_port()  #  pylint: disable=protected-access
+        interface._set_default_port()
         self.assertEqual(interface.interface["port"], "623")
 
         # Test for JMX type (4)
         interface.interface["type"] = 4
-        interface._set_default_port()  #  pylint: disable=protected-access
+        interface._set_default_port()
         self.assertEqual(interface.interface["port"], "12345")
 
         # Test for unsupported type
         interface.interface["type"] = 99
-        result = interface._set_default_port()  #  pylint: disable=protected-access
+        result = interface._set_default_port()
         self.assertFalse(result)
 
     def test_set_snmp_v2(self):