NeoAnd/knowledge
1
0
Fork 0
mirror of https://github.com/OCA/knowledge.git synced 2025-07-22 20:12:04 -06:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

[16.0][FIX] document_page_tag: Use api.model_create_multi

Browse Source 
Using decorator api.model_create_multi for create
method in document_page_tag model
This commit is contained in:
anusrinps96 2024-07-16 10:15:09 +02:00
parent b1ef710177
commit 9d749c8931
2 changed files with 27 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
document_page_tag/models/document_page_tag.py
View File

@ -15,10 +15,13 @@ class DocumentPageTag(models.Model):
("unique_name", "unique(name)", "Tags must be unique"),
]
@api.model
def create(self, vals):
@api.model_create_multi
def create(self, vals_list):
"""Be nice when trying to create duplicates"""
existing = self.search([("name", "=ilike", vals["name"])], limit=1)
if existing:
return existing
return super().create(vals)
for vals in vals_list:
existing = self.search([("name", "=ilike", vals["name"])], limit=1)
if existing:
vals_list.remove(vals)
if not vals_list:
return existing
return super().create(vals_list)

23
document_page_tag/tests/test_document_page_tag.py
View File

@ -8,15 +8,28 @@ from odoo.tools.misc import mute_logger
class TestDocumentPageTag(TransactionCase):
def test_document_page_tag(self):
testtag = self.env["document.page.tag"].name_create("test")
test_tag = self.env["document.page.tag"].name_create("test")
# check we're charitable on duplicates
self.assertEqual(
testtag,
test_tag,
self.env["document.page.tag"].name_create("Test"),
)
# check multiple record creation
test_tag1 = self.env["document.page.tag"].create(
[{"name": "test1"}, {"name": "test"}, {"name": "test2"}]
)
self.assertEqual(len(test_tag1), 2)
self.assertEqual(test_tag1[0].name, "test1")
self.assertEqual(test_tag1[1].name, "test2")
# check single record creation where record already exist
test_tag2 = self.env["document.page.tag"].create([{"name": "test"}])
self.assertEqual(len(test_tag2), 1)
self.assertEqual(test_tag2[0].name, "test")
# check we can't create nonunique tags
with self.assertRaises(IntegrityError):
with mute_logger("odoo.sql_db"):
testtag2 = self.env["document.page.tag"].create({"name": "test2"})
testtag2.write({"name": "test"})
testtag2.flush_model()
test_tag3 = self.env["document.page.tag"].create([{"name": "test3"}])
test_tag3.write({"name": "test"})
test_tag3.flush_model()