Merge PR #284 into 12.0

Signed-off-by pedrobaeza

document_page_approval/models/document_page_history.py

@@ -85,7 +85,7 @@ class DocumentPageHistory(models.Model):
                 users = self.env['res.users'].search([
                     ('groups_id', 'in', guids),
                     ('groups_id', 'in', approver_gid.id)])
-                rec.message_subscribe([u.id for u in users])
+                rec.message_subscribe(partner_ids=users.mapped('partner_id').ids)
                 rec.message_post_with_template(template.id)
             else:
                 # auto-approve if approval is not required

document_page_approval/readme/CONTRIBUTORS.rst

@@ -3,4 +3,8 @@
 * Gervais Naoussi <gervaisnaoussi@gmail.com>
 * Maxime Chambreuil <mchambreuil@opensourceintegrators.com>
 * Iván Todorovich <ivan.todorovich@gmail.com>
-* Victor M.M. Torres <victor.martin@tecnativa.com>
+
+* `Tecnativa <https://www.tecnativa.com>`_:
+
+    * Victor M.M. Torres
+    * Víctor Martínez

document_page_approval/tests/test_document_page_approval.py

@@ -15,6 +15,22 @@ class TestDocumentPageApproval(common.TransactionCase):
         self.env.ref('base.user_root').write({
             'groups_id': [(4, self.approver_gid.id)],
         })
+        self.user2 = self.env["res.users"].create(
+            {
+                "name": "Test user 2",
+                "login": "Test user 2",
+                "groups_id": [
+                    (
+                        6,
+                        0,
+                        [
+                            self.env.ref("base.group_user").id,
+                            self.approver_gid.id,
+                        ],
+                    )
+                ],
+            }
+        )
         # demo_approval
         self.category2 = self.page_obj.create({
             'name': 'This category requires approval',
@@ -43,6 +59,9 @@ class TestDocumentPageApproval(common.TransactionCase):
 
         # It should automatically be in 'to approve' state
         self.assertEqual(chreq.state, 'to approve')
+        user_root = self.env.ref('base.user_root')
+        self.assertTrue(user_root.partner_id.id in chreq.message_partner_ids.ids)
+        self.assertTrue(self.user2.partner_id.id in chreq.message_partner_ids.ids)
         self.assertNotEqual(chreq.content, page.content)
 
         # who_am_i