Jason Novinger
e57f9beced
Add render_config permission to ConfigTemplate render endpoint
...
Extend render_config permission requirement to the ConfigTemplate render
endpoint per issue comments.
Changes:
- Add TokenWritePermission check via get_permissions() override in
ConfigTemplateViewSet
- Restrict queryset to render_config permission in render() method
- Add explicit render_config permission check
- Add tests for ConfigTemplate.render() with and without permission
- Update documentation to include ConfigTemplate endpoint
2025-10-12 21:51:34 -05:00
Jason Novinger
8e72e75d61
Remove add permission requirement for render_config endpoint
...
Remove the add permission requirement from the render-config API endpoint
while maintaining token write_enabled enforcement as specified in #16681 .
Changes:
- Add TokenWritePermission class to check token write ability without requiring
specific model permissions
- Override get_permissions() in RenderConfigMixin to use TokenWritePermission
instead of TokenPermissions for render_config action
- Replace queryset restriction: use render_config instead of add
- Remove add permissions from tests - render_config permission now sufficient
- Update tests to expect 404 when permission denied (NetBox standard pattern)
Per #16681 : 'requirement for write permission makes sense for API calls
(because we're accepting and processing arbitrary user data), the specific
permission for creating devices does not'
2025-10-12 21:40:11 -05:00
Jason Novinger
196297c338
Correct permission denied message and enable translation
2025-10-12 20:42:09 -05:00
Jason Novinger
7de62418c5
Closes #16681 : Introduce render_config permission for configuration rendering
...
Add a new custom permission action `render_config` for rendering device and
virtual machine configurations via the REST API. This allows users to render
configurations without requiring the `add` permission.
Changes:
- Add permission check to RenderConfigMixin.render_config() for devices and VMs
- Update API tests to use render_config permission instead of add
- Add tests verifying permission enforcement (403 without render_config)
- Document new permission requirement in configuration-rendering.md
Note: Currently requires both render_config AND add permissions due to the
automatic POST='add' filter in BaseViewSet.initial(). Removing the add
requirement will be addressed in a follow-up commit.
2025-10-12 20:26:34 -05:00
bctiemann
a91af996d5
Merge pull request #20537 from netbox-community/17571-remove-htmx-navigation
...
CI / build (20.x, 3.12) (push) Has been cancelled
CI / build (20.x, 3.13) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, actions) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, javascript-typescript) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, python) (push) Has been cancelled
#17571 - Remove HTMX navigation
2025-10-09 17:49:35 -04:00
Brian Tiemann
bb290dc792
Remove from docs
2025-10-08 18:24:12 -04:00
Brian Tiemann
fcdb7ff6c8
Remove HTMX navigation
2025-10-08 14:33:23 -04:00
bctiemann
18a308ae3a
Merge pull request #20477 from netbox-community/20210-new-token-auth
...
CI / build (20.x, 3.12) (push) Has been cancelled
CI / build (20.x, 3.13) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, actions) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, javascript-typescript) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, python) (push) Has been cancelled
Closes #20210 : Implement new version of API token
2025-10-07 11:21:02 -04:00
Jeremy Stretch
c63e60a62b
Add a token prefix
CI / build (20.x, 3.12) (push) Has been cancelled
CI / build (20.x, 3.13) (push) Has been cancelled
2025-10-06 17:04:10 -04:00
Jeremy Stretch
82db8a9c02
Update documentation
CI / build (20.x, 3.12) (push) Has been cancelled
CI / build (20.x, 3.13) (push) Has been cancelled
2025-10-03 14:24:21 -04:00
Jeremy Stretch
bb75bceec5
Clean up tests
2025-10-03 13:55:48 -04:00
Jeremy Stretch
9a68cde95f
Merge branch 'feature' into 20210-new-token-auth
CI / build (20.x, 3.12) (push) Waiting to run
CI / build (20.x, 3.13) (push) Waiting to run
2025-10-03 12:09:21 -04:00
Jeremy Stretch
6c723dfb1a
Merge branch 'main' into feature
CI / build (20.x, 3.12) (push) Has been cancelled
CI / build (20.x, 3.13) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, actions) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, javascript-typescript) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, python) (push) Has been cancelled
2025-10-03 12:09:03 -04:00
Jeremy Stretch
9b85d92ad0
Clean up auth backend
2025-10-03 12:08:24 -04:00
Jeremy Stretch
917a2c2618
Validate peppers on init
2025-10-03 11:41:04 -04:00
Jeremy Stretch
6388705e57
Clean up TokenForm
2025-10-03 10:45:54 -04:00
Jeremy Stretch
ac335c3d87
Clean up filterset tests
2025-10-03 10:26:13 -04:00
Jeremy Stretch
a54c508da2
Misc cleanup
2025-10-03 09:58:20 -04:00
Jeremy Stretch
d69042f26e
Clean up token tables
2025-10-03 09:53:44 -04:00
Jeremy Stretch
f6290dd7af
Toggle plaintext display for v1 tokens
2025-10-03 09:16:50 -04:00
Jason Novinger
c094699dc0
Fixes #20484 : Configure CodeQL to exclude URL redirect false positives
CodeQL / Analyze (${{ matrix.language }}) (none, javascript-typescript) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, actions) (push) Has been cancelled
CI / build (20.x, 3.10) (push) Has been cancelled
CI / build (20.x, 3.11) (push) Has been cancelled
CI / build (20.x, 3.12) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, python) (push) Has been cancelled
2025-10-03 08:48:02 -04:00
Martin Hauser
5f77d684e1
chore(core): Remove unused imports in plugins and migrations
...
CI / build (20.x, 3.10) (push) Waiting to run
CI / build (20.x, 3.11) (push) Waiting to run
CI / build (20.x, 3.12) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, actions) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, javascript-typescript) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, python) (push) Waiting to run
Cleans up unused imports across `plugins.py` and a migration file.
Closes #20482
2025-10-02 17:11:07 -04:00
Jeremy Stretch
adce67a7cf
Standardize on the use of v2 tokens in tests
2025-10-02 16:37:28 -04:00
Jeremy Stretch
f82f084c02
Misc cleanup
2025-10-02 16:33:04 -04:00
Jeremy Stretch
43fc7fb58a
Add constraints to enforce v1/v2-dependent fields
2025-10-02 16:05:09 -04:00
Jeremy Stretch
11099b01bb
Rename pepper field to pepper_id for clarity
2025-10-02 15:38:17 -04:00
Jeremy Stretch
5dc48f3a88
Enforce a fixed key length for v2 tokens
2025-10-02 15:26:22 -04:00
Jeremy Stretch
1ee23ba6fa
Initial work on #20210
2025-10-02 15:04:29 -04:00
github-actions
f23eb53312
Update source translation strings
CodeQL / Analyze (${{ matrix.language }}) (none, actions) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, javascript-typescript) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, python) (push) Has been cancelled
CI / build (20.x, 3.10) (push) Waiting to run
CI / build (20.x, 3.11) (push) Waiting to run
CI / build (20.x, 3.12) (push) Waiting to run
2025-10-02 05:02:10 +00:00
bctiemann
91d5d284ca
Merge pull request #20464 from netbox-community/20248-fix-translation-error
...
Fixes #20248 : Tweak help text to avoid error when compiling translations
2025-10-01 20:45:42 -04:00
Jeremy Stretch
23d7515b41
Merge branch 'main' into feature
CodeQL / Analyze (${{ matrix.language }}) (none, javascript-typescript) (push) Has been cancelled
CI / build (20.x, 3.12) (push) Has been cancelled
CI / build (20.x, 3.13) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, actions) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, python) (push) Has been cancelled
2025-10-01 08:03:43 -04:00
github-actions
c4dcc62c04
Update source translation strings
CodeQL / Analyze (${{ matrix.language }}) (none, python) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, javascript-typescript) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, actions) (push) Waiting to run
2025-10-01 05:02:17 +00:00
Jeremy Stretch
5a96b76cd4
Release v4.4.2
CodeQL / Analyze (${{ matrix.language }}) (none, actions) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, javascript-typescript) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, python) (push) Waiting to run
CI / build (20.x, 3.10) (push) Has been cancelled
CI / build (20.x, 3.11) (push) Has been cancelled
CI / build (20.x, 3.12) (push) Has been cancelled
v4.4.2
2025-09-30 16:14:35 -04:00
Jeremy Stretch
26fc06b817
Fixes #20248 : Tweak help text to avoid error when compiling translations
2025-09-30 15:10:53 -04:00
Jeremy Stretch
9bc60a157b
Fixes #20243 : Prevent scheduled system jobs from re-running multiple times ( #20450 )
2025-09-30 13:27:31 -05:00
Jeremy Stretch
28cc8e5c89
Fixes #18878 : Automatically assign a designated primary MAC address upon creation of a new interface ( #20457 )
2025-09-30 13:26:52 -05:00
Martin Hauser
ba1c0d6d84
Closes #20449 : Add user preferences documentation ( #20460 )
2025-09-30 13:16:36 -05:00
Jeremy Stretch
f31a5551ff
Closes #19765 : Linkify object types under saved filter view ( #20458 )
CI / build (20.x, 3.10) (push) Waiting to run
CI / build (20.x, 3.11) (push) Waiting to run
CI / build (20.x, 3.12) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, actions) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, javascript-typescript) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, python) (push) Waiting to run
2025-09-30 08:29:59 -07:00
Jeremy Stretch
b0a8b86a93
#20382 : Additional GraphQL API tips ( #20451 )
...
* #20382 : Additional GraphQL API tips
* Add graphql hint for syntax highlighting
2025-09-30 11:29:29 -04:00
Jeremy Stretch
d222466882
Fixes #20245 : Fix Markdown preview functionality within "quick add" modal
2025-09-30 11:19:50 -04:00
Martin Hauser
9e75a2f955
fix(api): Fix schema and field definitions for OpenAPI
...
Add `get_internal_type()` to custom field classes for Django compatibility,
annotate path parameters and operation IDs for background endpoints, and
provide serializer context on the RQ base viewset to clear schema warnings.
Fixes #20365
2025-09-30 10:46:03 -04:00
Jeremy Stretch
10e76597a8
Closes #20332 : Add a "none" option to object tag filters ( #20452 )
2025-09-30 09:45:15 -05:00
Martin Hauser
18862586e5
feat(dcim): Add "facility" field to bulk edit forms for Site and Location
...
Introduces a new "facility" field in the bulk edit forms for Site and
Location models. Updates fieldsets and nullable fields to incorporate
the "facility" field.
Closes #20438
2025-09-30 08:48:26 -04:00
github-actions
69a7c97c3e
Update source translation strings
CodeQL / Analyze (${{ matrix.language }}) (none, actions) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, javascript-typescript) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, python) (push) Waiting to run
2025-09-30 05:04:06 +00:00
Jeremy Stretch
bfd1adf0b5
Fixes #20441 : Fix display of the "groups" column in contact assignments table ( #20446 )
CI / build (20.x, 3.10) (push) Waiting to run
CI / build (20.x, 3.11) (push) Waiting to run
CI / build (20.x, 3.12) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, actions) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, javascript-typescript) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, python) (push) Waiting to run
2025-09-29 13:05:52 -05:00
Robert Drake
030f03b1a8
Typo and alphabetical fixes for Interface choices
...
This fixes the alphabetical ordering of the interface types, and it
corrects the typo in the BiDi names.
fixes #20392
2025-09-29 13:38:37 -04:00
Jeremy Stretch
6cf6e2cd7f
Fixes #20419 : Correct action buttons for child object views ( #20445 )
2025-09-29 09:14:16 -07:00
RasmusThing
0b7baae23c
Fixes #20412 : linkify cluster type ( #20413 )
CI / build (20.x, 3.10) (push) Waiting to run
CI / build (20.x, 3.11) (push) Waiting to run
CI / build (20.x, 3.12) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, actions) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, javascript-typescript) (push) Waiting to run
CodeQL / Analyze (${{ matrix.language }}) (none, python) (push) Waiting to run
2025-09-29 06:44:15 -05:00
Elliott Balsley
0c22fc9408
Fixes #19590 : Display related columns on DeviceComponents table ( #20344 )
2025-09-29 05:45:37 -05:00
bctiemann
a437931aef
Merge pull request #20393 from netbox-community/20390-pagination-dropdown
...
CI / build (20.x, 3.10) (push) Has been cancelled
CI / build (20.x, 3.11) (push) Has been cancelled
CI / build (20.x, 3.12) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, actions) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, javascript-typescript) (push) Has been cancelled
CodeQL / Analyze (${{ matrix.language }}) (none, python) (push) Has been cancelled
Fixes #20390 : Fix styling of pagination dropdown menu
2025-09-22 07:15:53 -04:00