NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-27 10:58:37 -06:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity
14,003 Commits 55 Branches 337 Tags 179 MiB
680f907208
Commit Graph

14003 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jason Novinger
b85a5f471b Extract base NestedGroupModelFilterSet with base search behavior 
This can easily be extended (as in the case of LocationFilterSet) by
calling super() and ORing a filter to the queryset that is returned.
See: https://docs.djangoproject.com/en/5.1/ref/models/querysets/#or
 2025-03-13 15:36:55 -05:00
Jeremy Stretch
2d310cee72 Fixes #18872: JournalEntry kind is a required field 2025-03-13 16:23:53 -04:00
Jason Novinger
cbe3f39eb5 Ensures overridden filterset search() methods include fields from OrganizationalModelFilterSet 2025-03-13 11:52:06 -05:00
Jason Novinger
e33c1f1173 Ensures that all new comments fields render Markdown in tables 2025-03-13 11:52:06 -05:00
Jason Novinger
d557936c98 Adds WirelessLANGroup.comments to all the required places 
- [x] 1. Add the field to the model class
- [x] 2. Generate and run database migrations
- [NA] 3. Add validation logic to clean()
- [NA] 4. Update relevant querysets
- [x] 5. Update API serializer
- [x] 6. Add fields to forms
    - [x] wireless.forms.model_forms, create/edit (e.g. model_forms.py)
    - [x] wireless.forms.bulk_edit, bulk edit
    - [x] wireless.forms.bulk_import, CSV import
    - [NA] filter (UI and API)
- [x] 7. Extend object filter set
- [NA] 8. Add column to object table (Note: was already present)
- [x] 9. Update the SearchIndex
- [x] 10. Update the UI templates
- [x] 11. Create/extend test cases
    - [NA] models
    - [x] views
    - [NA] forms
    - [x] filtersets
    - [x] api
- [NA] 12. Update the model's documentation
 2025-03-13 11:52:06 -05:00
Jason Novinger
e15468f8eb Adds TenantGroup.comments to the required locations 
- [x] 1. Add the field to the model class
- [x] 2. Generate and run database migrations
- [NA] 3. Add validation logic to clean()
- [NA] 4. Update relevant querysets
- [x] 5. Update API serializer
- [x] 6. Add fields to forms
    - [x] tenancy.forms.model_forms, create/edit (e.g. model_forms.py)
    - [x] tenancy.forms.bulk_edit, bulk edit
    - [x] tenancy.forms.bulk_import, CSV import
    - [NA] filter (UI and API)
- [x] 7. Extend object filter set
- [x] 8. Add column to object table
- [x] 9. Update the SearchIndex
- [x] 10. Update the UI templates
- [x] 11. Create/extend test cases
    - [NA] models
    - [x] views
    - [NA] forms
    - [x] filtersets
    - [x] api
- [NA] 12. Update the model's documentation
 2025-03-13 11:52:06 -05:00
Jason Novinger
790acd01e5 Adds ContactGroup.comments in the required locations 
- [x] 1. Add the field to the model class
- [x] 2. Generate and run database migrations
- [NA] 3. Add validation logic to clean()
- [NA] 4. Update relevant querysets
- [x] 5. Update API serializer
- [x] 6. Add fields to forms
    - [x] tenancy.forms.model_forms, create/edit (e.g. model_forms.py)
    - [x] tenancy.forms.buld_edit, bulk edit
    - [x] tenancy.dorms.bulk_import, CSV import
    - [NA] filter (UI and API)
- [x] 7. Extend object filter set
- [x] 8. Add column to object table
- [x] 9. Update the SearchIndex
- [x] 10. Update the UI templates
- [x] 11. Create/extend test cases
    - [NA] models
    - [x] views
    - [NA] forms
    - [x] filtersets
    - [x] api
- [NA] 12. Update the model's documentation
 2025-03-13 11:52:06 -05:00
Jason Novinger
f487214398 Adds SiteGroup.comments in the required locations 
- [x] 1. Add the field to the model class
- [x] 2. Generate and run database migrations
- [NA] 3. Add validation logic to clean()
- [NA] 4. Update relevant querysets
- [x] 5. Update API serializer
- [x] 6. Add fields to forms
    - [x] dcim.forms.model_forms.LocationForm, create/edit (e.g. model_forms.py)
    - [x] dcim.forms.buld_edit.LocationBulkEditForm, bulk edit
    - [x] dcim.dorms.bulk_import.LocationImportForm, CSV import
    - [x] filter (UI and API)
- [x] 7. Extend object filter set
- [x] 8. Add column to object table
- [x] 9. Update the SearchIndex
- [x] 10. Update the UI templates
- [x] 11. Create/extend test cases
    - [NA] models
    - [x] views
    - [NA] forms
    - [x] filtersets
    - [x] api
- [x] 12. Update the model's documentation
 2025-03-13 11:52:06 -05:00
Jason Novinger
6391eb598f Adds Region.comments field in the required locations 
- [x] 1. Add the field to the model class
- [x] 2. Generate and run database migrations
- [NA] 3. Add validation logic to clean()
- [NA] 4. Update relevant querysets
- [x] 5. Update API serializer
- [ ] 6. Add fields to forms
    - [x] dcim.forms.model_forms.RegionForm, create/edit (e.g. model_forms.py)
    - [x] dcim.forms.buld_edit.RegionBulkEditForm, bulk edit
    - [x] dcim.dorms.bulk_import.RegionImportForm, CSV import
    - [NA] filter (UI and API)
- [x] 7. Extend object filter set
- [x] 8. Add column to object table
- [x] 9. Update the SearchIndex
- [x] 10. Update the UI templates
- [x] 11. Create/extend test cases
    - [NA] models
    - [x] views
    - [NA] forms
    - [x] filtersets
    - [x] api
- [NA] 12. Update the model's documentation
 2025-03-13 11:52:06 -05:00
Jason Novinger
5097a64e6a Update Location detail UI template 2025-03-13 11:52:06 -05:00
Jason Novinger
5fc888bfad Adds Location.comments field in the required locations 
- [x] 1. Add the field to the model class
- [x] 2. Generate and run database migrations
- [NA] 3. Add validation logic to clean()
- [NA] 4. Update relevant querysets
- [x] 5. Update API serializer
- [x] 6. Add fields to forms
    - [x] dcim.forms.model_forms.LocationForm, create/edit (e.g. model_forms.py)
    - [x] dcim.forms.buld_edit.LocationBulkEditForm, bulk edit
    - [x] dcim.dorms.bulk_import.LocationImportForm, CSV import
    - [x] filter (UI and API)
        - [NA] UI
            - Note: could not find any comments related things in filtersets
        - [x] API
- [x] 7. Extend object filter set
- [x] 8. Add column to object table
- [x] 9. Update the SearchIndex
- [x] 10. Update the UI templates
- [x] 11. Create/extend test cases
    - [NA] models
    - [x] views
    - [NA] forms
    - [x] filtersets
    - [x] api
- [NA] 12. Update the model's documentation
 2025-03-13 11:52:06 -05:00
Jason Novinger
d3a88a4c81 Adds comments field to abstract NestedGroupModel and associated migrations 
Models affected:
- dcim: `Location`, `Region`, `SiteGroup`
- tenancy`: `ContactGroup`, `TenantGroup`
- wireless: `WirelessLANGroup`
 2025-03-13 11:52:06 -05:00
Jeremy Stretch
d639e829ec Fixes #18880: Delay enqueuing of background tasks until the DB transaction has been committed (#18899) 2025-03-13 11:34:12 -05:00
bctiemann
84d799b663 Merge pull request #18822 from netbox-community/18743-django-52 
Closes #18743: Upgrade to Django 5.2
 2025-03-13 10:58:58 -04:00
Tobias Genannt
f4581ae388 Fixes: #18568 Update mkdocstrings and adapt config 2025-03-13 10:25:42 -04:00
Jeremy Stretch
2b771a8a35 Adapt RemoteUserMiddleware for Django 5.2 2025-03-13 09:34:00 -04:00
Jeremy Stretch
116d42de74 Closes #18743: Upgrade to Django 5.2 2025-03-13 09:34:00 -04:00
Jason Novinger
9d16cd21f4 Fixes #18845: restores sort behavior for DeviceTable.name column (#18861) 
* Fixes #18845: restores sort behavior for DeviceTable.name column

* Remove accessor/order_by and modify DEVICE_LINK template

Thanks to @alehaa for the suggestion.

This also includes an additional `.select_related()` operation on
`DeviceListView.queryset` to avoid extra queries. Thanks to
@renatoalmeidaoliveira and @jeremystretch for pointing out the need for
this.
 2025-03-13 09:22:49 -04:00
github-actions
dc869458dc Update source translation strings 2025-03-13 05:02:07 +00:00
bctiemann
640cdf57e9 Merge pull request #18886 from ITJamie/add-rackname-to-device-rack-view 
Add rack title above rack view on device page
 2025-03-12 19:11:22 -04:00
bctiemann
1199f9836f Merge pull request #18826 from Tishka17/fix/generic_prefetch_4.2 
Prefetch interface data for REST API on netbox 4.2
 2025-03-12 18:55:58 -04:00
Jeremy Stretch
1ad63fce12 Fixes #18869: Ensure to_meters() always returns a clean decimal value (#18883) 
* Fixes #18869: Ensure to_meters() always returns a clean decimal value

* Handle float values
 2025-03-12 13:42:38 -05:00
Andrey Tikhonov
56107a3857 Merge branch 'fix/generic_prefetch_4.2' of github.com:Tishka17/netbox into fix/generic_prefetch_4.2 2025-03-12 19:13:34 +01:00
Andrey Tikhonov
f6160067a3 Fix empty line, comments 2025-03-12 19:09:46 +01:00
Renato Almeida de Oliveira
30ba10dce8 Change JSONField, prepare_value to output str with enclosing " (#18846) 2025-03-12 10:00:40 -07:00
Andrey Tikhonov
f160cdb2a9 Merge branch 'main' into fix/generic_prefetch_4.2 2025-03-12 16:27:12 +01:00
Andrey Tikhonov
c54a7c8cb0 Move GenericArrayForeignKey to fields module 2025-03-12 16:22:11 +01:00
github-actions
4fd572ef2f Update source translation strings 2025-03-12 05:02:02 +00:00
Fabi
9fc63ba52c Fixes #18838: Correctly reject invalid falsy local context data (#18860) 
* Correctly reject invalid falsy local context data.

* move tests
 2025-03-11 14:18:42 -05:00
bctiemann
4c2eea0dfe Merge pull request #18804 from renatoalmeidaoliveira/18742-Location-List-and-Locations-not-Showing-Associated-VLAN-Groups 
Fixes: #18742 Location List and Locations not Showing Associated VLAN Groups
 2025-03-11 11:13:24 -04:00
Renato Almeida de Oliveira
922c400c4e Fixes: #18582 Bulk import prefixes with associated VLAN not working when multiple VLANs with the same vid exist. (#18844) 
* Add site CSVModelChoiceField

* Change site field to vlan_site
 2025-03-11 08:46:46 -04:00
github-actions
ea1b2d49be Update source translation strings 2025-03-11 05:02:10 +00:00
Jeremy Stretch
d873109967 Closes #18857: Fix deprecation warnings (#18858) 2025-03-10 14:40:08 -07:00
Antoine Keranflec'h
b74ec7854d Fixes: #18744 Add Contact link as hyperlink (#18847) 
* contact link as hyperlink

* fix(lint) add missing blank lines

* simplify by using lambda function
 2025-03-10 12:49:24 -05:00
Tobias Genannt
c1074b6c8e Fixes: #18568 Update mkdocstrings and adapt config (#18841) 
* Fixes: #18568 Update mkdocstrings and adapt config

* Fixed some output formatting errors

When trying to compare the output from "mkdocstrings[python-legacy]==0.27.0" and
"mkdocstrings[python]==0.28.2" I encountered some HTML errors:
- <div> inside a <p>
- unescaped non-tags <pk>
 2025-03-10 13:11:35 -04:00
Jason Novinger
7d9182aef0 Adds validation for ObjectListWidget.ConfigForm.model field 2025-03-10 09:57:45 -05:00
Jason Novinger
ce0d19d43d Fixes #18782: properly check if htmx_url is None 
If this is done incorrently, then the string formatting operation turns
`htmx_url` into a string and the test in the template fails.
 2025-03-10 09:52:59 -05:00
bctiemann
f738b518fe Closes: #18535 - Skip incompatible plugins during startup (#18537) 
* Skip incompatible plugins during startup and remove from PLUGINS

* Handle exceptions on request processors in incompatible plugins, and display status in Plugins page

* Revert "Handle exceptions on request processors in incompatible plugins, and display status in Plugins page"

This reverts commit d97bf2ab146114cc13d751878a17a383de0fd5f8.

* Resolve merge conflicts

* Skip incompatible plugins during startup and remove from PLUGINS

* Rename Installed column to Active, and add custom PluginActiveColumn with tooltip

* Fix is_installed

* Simplify plugin_config.validate syntax

Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

* Merge feature

* Revert "Merge feature"

This reverts commit d1ea60f082.

* Undo simplification

* Add failed_to_load logic

* Use a TemplateColumn for is_installed

* Remove custom column class

* Remove merge vestige

* Simplify plugin attributes for is_installed column

* Use placeholders for false values to increase legibility of the plugins table

---------

Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
 2025-03-10 10:51:41 -04:00
github-actions
8398cec49b Update source translation strings 2025-03-08 05:02:21 +00:00
Jeremy Stretch
8f39c645b4 Closes #7598: Enable custom field filtering for GraphQL (#18701) 2025-03-07 10:49:06 -08:00
Mika Busch
44062fb94d 17686 config option for disk divider (#18011) 2025-03-07 10:47:27 -08:00
bctiemann
34f0afecb6 Fixes: #18808 - Fix incorrect dependencies on squashed migrations (#18827) 2025-03-07 10:20:34 -08:00
Andrey Tikhonov
aed90b7c83 Removed automatic cache invalidation 2025-03-07 17:29:04 +01:00
github-actions
a7511d8580 Update source translation strings 2025-03-07 05:02:48 +00:00
Jason Novinger
306a67346f Closes #17608: Adds L2VPN.status field (#18791) 2025-03-06 14:06:06 -08:00
bctiemann
81333e7b3b Add docstrings for get_queryset base class methods (#18832) 2025-03-06 11:11:55 -06:00
Renato Almeida de Oliveira
7526f3c29c Fixes: #18579 Add contact filters to services (#18818) 
* Add Contact filter to Services

* Add ContactModelFilterForm to ProviderAccountFilterForm

* Add Contact filter support for Aggregate

* Add Contact filter support for Prefix

* Add Contact filter to IPRange

* Add Contact filter to IPAddress

* Add Contact filter to L2VPN

* Add Contact filter to TunnelGroup

* Add Contact filter to Tunnel

* Add ContactModelFilterSet to ProviderAccountFilterSet

* Fixes classes inheritance order

Setup NetBoxModelFilterSetForm as the last inherited class

Co-authored-by: Jason Novinger <jnovinger@gmail.com>

---------

Co-authored-by: Jason Novinger <jnovinger@gmail.com>
 2025-03-06 09:41:41 -06:00
bctiemann
a0d48246fe Merge pull request #18823 from netbox-community/release-v4.2.5 
Release v4.2.5
 2025-03-06 10:10:13 -05:00
Andrey Tikhonov
2e0edda745 Merge branch 'develop' into fix/generic_prefetch_4.2 2025-03-06 16:05:25 +01:00
Andrey Tikhonov
dc5bf79d64 Merge branch 'develop' into fix/generic_prefetch_4.2 2025-03-06 16:02:32 +01:00