NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-07 04:27:27 -06:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

Fixes #3868: Fix creation of interfaces for virtual machines

Browse Source
This commit is contained in:
Jeremy Stretch
2020-01-09 14:53:18 -05:00
parent 40fe6666e3
commit fe490d144a
6 changed files with 31 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
netbox/dcim/models.py
View File

@@ -22,6 +22,7 @@ from utilities.fields import ColorField
from utilities.managers import NaturalOrderingManager
from utilities.models import ChangeLoggedModel
from utilities.utils import foreground_color, serialize_object, to_meters
from virtualization.choices import VMInterfaceTypeChoices
from .choices import *
from .constants import *
@@ -2510,9 +2511,9 @@ class Interface(CableTermination, ComponentModel):
raise ValidationError("An interface must belong to either a device or a virtual machine.")
# VM interfaces must be virtual
if self.virtual_machine and self.type is not InterfaceTypeChoices.TYPE_VIRTUAL:
if self.virtual_machine and self.type not in VMInterfaceTypeChoices.values():
raise ValidationError({
'type': "Virtual machines can only have virtual interfaces."
'type': "Invalid interface type for a virtual machine: {}".format(self.type)
})
# Virtual interfaces cannot be connected