From fc3693e038479f4e7d051563312b815e7e2cabf2 Mon Sep 17 00:00:00 2001
From: Arthur <worldnomad@gmail.com>
Date: Thu, 11 Jan 2024 07:14:47 -0800
Subject: [PATCH] 14728 remove plugins view from admin

---
 netbox/netbox/plugins/urls.py                 |  3 -
 netbox/netbox/plugins/views.py                | 11 ----
 netbox/netbox/urls.py                         |  3 +-
 .../templates/extras/admin/plugins_list.html  | 58 -------------------
 4 files changed, 1 insertion(+), 74 deletions(-)
 delete mode 100644 netbox/templates/extras/admin/plugins_list.html

diff --git a/netbox/netbox/plugins/urls.py b/netbox/netbox/plugins/urls.py
index 2f237f56a..075bda811 100644
--- a/netbox/netbox/plugins/urls.py
+++ b/netbox/netbox/plugins/urls.py
@@ -15,9 +15,6 @@ plugin_api_patterns = [
     path('', views.PluginsAPIRootView.as_view(), name='api-root'),
     path('installed-plugins/', views.InstalledPluginsAPIView.as_view(), name='plugins-list')
 ]
-plugin_admin_patterns = [
-    path('installed-plugins/', staff_member_required(views.InstalledPluginsAdminView.as_view()), name='plugins_list')
-]
 
 # Register base/API URL patterns for each plugin
 for plugin_path in settings.PLUGINS:
diff --git a/netbox/netbox/plugins/views.py b/netbox/netbox/plugins/views.py
index 5971f78ef..777a4c69e 100644
--- a/netbox/netbox/plugins/views.py
+++ b/netbox/netbox/plugins/views.py
@@ -12,17 +12,6 @@ from rest_framework.reverse import reverse
 from rest_framework.views import APIView
 
 
-class InstalledPluginsAdminView(View):
-    """
-    Admin view for listing all installed plugins
-    """
-    def get(self, request):
-        plugins = [apps.get_app_config(plugin) for plugin in settings.PLUGINS]
-        return render(request, 'extras/admin/plugins_list.html', {
-            'plugins': plugins,
-        })
-
-
 @extend_schema(exclude=True)
 class InstalledPluginsAPIView(APIView):
     """
diff --git a/netbox/netbox/urls.py b/netbox/netbox/urls.py
index 984358911..7f37f01f1 100644
--- a/netbox/netbox/urls.py
+++ b/netbox/netbox/urls.py
@@ -9,7 +9,7 @@ from account.views import LoginView, LogoutView
 from netbox.api.views import APIRootView, StatusView
 from netbox.graphql.schema import schema
 from netbox.graphql.views import GraphQLView
-from netbox.plugins.urls import plugin_admin_patterns, plugin_patterns, plugin_api_patterns
+from netbox.plugins.urls import plugin_patterns, plugin_api_patterns
 from netbox.views import HomeView, StaticMediaFailureView, SearchView, htmx
 from .admin import admin_site
 
@@ -73,7 +73,6 @@ _patterns = [
 
     # Admin
     path('admin/background-tasks/', include('django_rq.urls')),
-    path('admin/plugins/', include(plugin_admin_patterns)),
     path('admin/', admin_site.urls),
 ]
 
diff --git a/netbox/templates/extras/admin/plugins_list.html b/netbox/templates/extras/admin/plugins_list.html
deleted file mode 100644
index 6795c66e6..000000000
--- a/netbox/templates/extras/admin/plugins_list.html
+++ /dev/null
@@ -1,58 +0,0 @@
-{% extends "admin/base_site.html" %}
-{% load i18n %}
-
-{% block title %}{% trans "Installed Plugins" %} {{ block.super }}{% endblock %}
-
-{% block breadcrumbs %}
-    <div class="breadcrumbs">
-        <a href="{% url 'admin:index' %}">{% trans "Home" %}</a> &rsaquo;
-        <a href="{% url 'plugins_list' %}">{% trans "Installed Plugins" %}</a>
-    </div>
-{% endblock %}
-
-{% block content_title %}<h1>{% trans "Installed Plugins" %}{{ queue.name }}</h1>{% endblock %}
-
-{% block content %}
-<div id="content-main">
-    <div class="module" id="changelist">
-        <div class="results">
-            <table id="result_list">
-                <thead>
-                    <tr>
-                        <th><div class="text"><span>{% trans "Name" %}</span></div></th>
-                        <th><div class="text"><span>{% trans "Package Name" %}</span></div></th>
-                        <th><div class="text"><span>{% trans "Author" %}</span></div></th>
-                        <th><div class="text"><span>{% trans "Author Email" %}</span></div></th>
-                        <th><div class="text"><span>{% trans "Description" %}</span></div></th>
-                        <th><div class="text"><span>{% trans "Version" %}</span></div></th>
-                    </tr>
-                </thead>
-                <tbody>
-                    {% for plugin in plugins %}
-                        <tr class="{% cycle 'row1' 'row2' %}">
-                            <td>
-                                {{ plugin.verbose_name }}
-                            </td>
-                            <td>
-                                {{ plugin.name }}
-                            </td>
-                            <td>
-                                {{ plugin.author }}
-                            </td>
-                            <td>
-                                {{ plugin.author_email }}
-                            </td>
-                            <td>
-                                {{ plugin.description }}
-                            </td>
-                            <td>
-                                {{ plugin.version }}
-                            </td>
-                        </tr>
-                    {% endfor %}
-                </tbody>
-            </table>
-        </div>
-    </div>
-</div>
-{% endblock %}