From fa2d7f651624c32dab8abbd09a31dfe983b27c9b Mon Sep 17 00:00:00 2001 From: Jason Novinger Date: Wed, 23 Jul 2025 05:35:48 -0500 Subject: [PATCH] Fixes #19916: restore Rack device representation behavior The select list of 'Images and Label', 'Images Only', and 'Label Only' was broken during recent work while implementing #19823. This fixes the issue by placing the `rack_elevation` class attribute on the
element that contains the SVG after being loaded by HTMX. In addition, we needed to slightly modify the selectors in the frontend code that looked for the elements within the SVG to hide and/or show. Previously, it was looking inside of a contentDocument embedded in an element. The simplified version just looks inside of the SVG containing div. --- netbox/project-static/dist/netbox.js | Bin 382259 -> 382185 bytes netbox/project-static/dist/netbox.js.map | Bin 1733549 -> 1733459 bytes netbox/project-static/src/racks.ts | 4 ++-- netbox/templates/dcim/inc/rack_elevation.html | 2 +- 4 files changed, 3 insertions(+), 3 deletions(-) diff --git a/netbox/project-static/dist/netbox.js b/netbox/project-static/dist/netbox.js index c4dd844613e531feb5575b7d7d79f81a7733cd17..9e2d6b383c2f22e003900f3bd894ce5d117a9676 100644 GIT binary patch delta 118 zcmdnIO8n(Y@rD-07N!>F7M3lnRVTQub5ctbN^CVUZBwTojA0R(zV8GphiIl%bgXq+ fevt-9wn!mAO`$}yX!`9FtVX10*q(Qi^(Z$0F7M3lnRVO5LimY=|OB70MHHvICGHp}!lJoOQQu9hC9|#a< z%$$BOhDAhHQ_(iBG$+Tt$SOM4IxW9Q1EeEgAwNx_L^FT-wiB#IlpC{MF7M2#)7Pc1l7LFFq7OocV7M>Q~7QPn#7J(MQEkZs)(_@2# zzJiFj=?)9HSlW*U3jwh(5Q_k@C=iPQu{aP*Y(E+-d5_1X(AibT)6vn_S;yVcG2BJR z)zQ(>3q*$MWI8!IW;(g+I6FE9g4Ev#iYok6nY&LCkB)7j8vTB4*mqt|qcL`ek~ zZR(gOH~n&=WT0&j$i~D_kd4|-PzQnREOCtjxi=Cl6C4C`OE8dd%>g;f*Iy?X$PeG1 jm?Wvl$Q}e%ncUu)EV;ciSt^Tr`h80&@$CZnQgc}V2t;ZB delta 409 zcmccoEOYJi%!U@m7N!>F7M2#)7Pc1l7LFFq7OocV7M>Q~7QPn#7J(MQEkZs))Bm#a z$W8YP77Cnxe;pUc^i4rR{a~?npcoJf1F;AYivqD25Q_t`#CE@6Nn_qvM@MHJSI0tU zR~=7BM_*?hcSpx?7ZB;_0u*<2^a7EgI@wN+j$t~HKmkvXfRU3BoFQg98@omsZ%LIpjoEZ!xTyva(q_4kDFpwX)oi|BRk&!(FtTMITG+A=HX|hxnH&cAl K_Stz-J6Hgepmt#Z diff --git a/netbox/project-static/src/racks.ts b/netbox/project-static/src/racks.ts index cae9897fc..54b144363 100644 --- a/netbox/project-static/src/racks.ts +++ b/netbox/project-static/src/racks.ts @@ -35,7 +35,7 @@ function showRackElements( selector: string, elevation: HTMLObjectElement, ): void { - const elements = elevation.contentDocument?.querySelectorAll(selector) ?? []; + const elements = elevation.querySelectorAll(selector) ?? []; for (const element of elements) { element.classList.remove('hidden'); } @@ -45,7 +45,7 @@ function hideRackElements( selector: string, elevation: HTMLObjectElement, ): void { - const elements = elevation.contentDocument?.querySelectorAll(selector) ?? []; + const elements = elevation.querySelectorAll(selector) ?? []; for (const element of elements) { element.classList.add('hidden'); } diff --git a/netbox/templates/dcim/inc/rack_elevation.html b/netbox/templates/dcim/inc/rack_elevation.html index c51bcec24..d2fb62e0d 100644 --- a/netbox/templates/dcim/inc/rack_elevation.html +++ b/netbox/templates/dcim/inc/rack_elevation.html @@ -1,5 +1,5 @@ {% load i18n %} -
+