From f9ceaad2845ecde99a6faa4f63fdf802d11b85cd Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jstretch@netboxlabs.com>
Date: Tue, 26 Sep 2023 10:53:38 -0400
Subject: [PATCH] #13666: Add is_valid property to Report class

---
 netbox/extras/reports.py                 |  7 +++++++
 netbox/templates/extras/report.html      | 12 +++++++-----
 netbox/templates/extras/report_list.html | 18 ++++++++++--------
 3 files changed, 24 insertions(+), 13 deletions(-)

diff --git a/netbox/extras/reports.py b/netbox/extras/reports.py
index 284f69d77..9b12065ca 100644
--- a/netbox/extras/reports.py
+++ b/netbox/extras/reports.py
@@ -135,6 +135,13 @@ class Report(object):
     def source(self):
         return inspect.getsource(self.__class__)
 
+    @property
+    def is_valid(self):
+        """
+        Indicates whether the report can be run.
+        """
+        return bool(self.test_methods)
+
     #
     # Logging methods
     #
diff --git a/netbox/templates/extras/report.html b/netbox/templates/extras/report.html
index 717c24eab..806279d20 100644
--- a/netbox/templates/extras/report.html
+++ b/netbox/templates/extras/report.html
@@ -8,15 +8,17 @@
     {% if perms.extras.run_report %}
       <div class="row">
         <div class="col">
+          {% if not report.is_valid %}
+            <div class="alert alert-warning">
+              <i class="mdi mdi-alert"></i>
+              {% trans "This report is invalid and cannot be run." %}
+            </div>
+          {% endif %}
           <form action="{% url 'extras:report' module=report.module name=report.class_name %}" method="post" class="form-object-edit">
             {% csrf_token %}
             {% render_form form %}
             <div class="float-end">
-              <button type="submit" name="_run" class="btn btn-primary"
-              {% if not report.test_methods|length %}
-                disabled
-              {% endif %}
-              >
+              <button type="submit" name="_run" class="btn btn-primary"{% if not report.is_valid %} disabled{% endif %}>
                 {% if report.result %}
                   <i class="mdi mdi-replay"></i> {% trans "Run Again" %}
                 {% else %}
diff --git a/netbox/templates/extras/report_list.html b/netbox/templates/extras/report_list.html
index ff245d265..d4d3962c3 100644
--- a/netbox/templates/extras/report_list.html
+++ b/netbox/templates/extras/report_list.html
@@ -68,16 +68,18 @@
                           </td>
                         {% else %}
                           <td class="text-muted">{% trans "Never" %}</td>
-                          {% if report.test_methods|length %}
-                            <td>{{ ''|placeholder }}</td>
-                          {% else %}
-                            <td>
-                              Invalid (no test methods found)
-                           </td>
-                          {% endif %}
+                          <td>
+                            {% if report.is_valid %}
+                              {{ ''|placeholder }}
+                            {% else %}
+                              <span class="badge bg-danger" title="{% trans "Report has no test methods" %}">
+                                {% trans "Invalid" %}
+                              </span>
+                            {% endif %}
+                          </td>
                         {% endif %}
                         <td>
-                          {% if perms.extras.run_report and report.test_methods|length %}
+                          {% if perms.extras.run_report and report.is_valid %}
                             <div class="float-end noprint">
                               <form action="{% url 'extras:report' module=report.module name=report.class_name %}" method="post">
                                 {% csrf_token %}