From f469920759f8711c8443de9ee0892e042a895fd3 Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jeremy@netverity.dev>
Date: Wed, 20 Jan 2021 15:18:13 -0500
Subject: [PATCH] Fixes #5640: Fix permissions assessment when adding VM
 interfaces in bulk

---
 docs/release-notes/version-2.10.md                       | 1 +
 netbox/templates/virtualization/virtualmachine_list.html | 2 +-
 netbox/virtualization/views.py                           | 3 +++
 3 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/docs/release-notes/version-2.10.md b/docs/release-notes/version-2.10.md
index f3cf87764..0ef5f2a0f 100644
--- a/docs/release-notes/version-2.10.md
+++ b/docs/release-notes/version-2.10.md
@@ -14,6 +14,7 @@
 * [#5584](https://github.com/netbox-community/netbox/issues/5584) - Restore power utilization panel under device view
 * [#5597](https://github.com/netbox-community/netbox/issues/5597) - Fix ordering devices by primary IP address
 * [#5639](https://github.com/netbox-community/netbox/issues/5639) - Fix filtering connection lists by device name
+* [#5640](https://github.com/netbox-community/netbox/issues/5640) - Fix permissions assessment when adding VM interfaces in bulk
 
 ---
 
diff --git a/netbox/templates/virtualization/virtualmachine_list.html b/netbox/templates/virtualization/virtualmachine_list.html
index 9d8c1720f..245e55092 100644
--- a/netbox/templates/virtualization/virtualmachine_list.html
+++ b/netbox/templates/virtualization/virtualmachine_list.html
@@ -7,7 +7,7 @@
                 <span class="mdi mdi-plus-thick" aria-hidden="true"></span> Add Components <span class="caret"></span>
             </button>
             <ul class="dropdown-menu">
-                {% if perms.dcim.add_interface %}<li><a href="{% url 'virtualization:virtualmachine_bulk_add_vminterface' %}{% if request.GET %}?{{ request.GET.urlencode }}{% endif %}" class="formaction">Interfaces</a></li>{% endif %}
+                {% if perms.virtualization.add_vminterface %}<li><a href="{% url 'virtualization:virtualmachine_bulk_add_vminterface' %}{% if request.GET %}?{{ request.GET.urlencode }}{% endif %}" class="formaction">Interfaces</a></li>{% endif %}
             </ul>
         </div>
     {% endif %}
diff --git a/netbox/virtualization/views.py b/netbox/virtualization/views.py
index 9ef4a0863..dcf9ebcda 100644
--- a/netbox/virtualization/views.py
+++ b/netbox/virtualization/views.py
@@ -396,3 +396,6 @@ class VirtualMachineBulkAddInterfaceView(generic.BulkComponentCreateView):
     model_form = forms.VMInterfaceForm
     filterset = filters.VirtualMachineFilterSet
     table = tables.VirtualMachineTable
+
+    def get_required_permission(self):
+        return f'virtualization.add_vminterface'