diff --git a/netbox/dcim/models/device_component_templates.py b/netbox/dcim/models/device_component_templates.py
index 5f6aa08e3..3a71c424d 100644
--- a/netbox/dcim/models/device_component_templates.py
+++ b/netbox/dcim/models/device_component_templates.py
@@ -160,7 +160,6 @@ class ModularComponentTemplateModel(ComponentTemplateModel):
def _get_module_tree(self, module):
modules = []
- all_module_bays = module.device.modulebays.all().select_related('module')
while module:
modules.append(module)
if module.module_bay:
diff --git a/netbox/dcim/tests/test_models.py b/netbox/dcim/tests/test_models.py
index 1c3dbb90b..70431c2e1 100644
--- a/netbox/dcim/tests/test_models.py
+++ b/netbox/dcim/tests/test_models.py
@@ -662,10 +662,8 @@ class ModuleBayTestCase(TestCase):
def test_module_bay_recursion(self):
module_bay_1 = ModuleBay.objects.get(name='Module Bay 1')
- module_bay_2 = ModuleBay.objects.get(name='Module Bay 2')
module_bay_3 = ModuleBay.objects.get(name='Module Bay 3')
module_1 = Module.objects.get(module_bay=module_bay_1)
- module_2 = Module.objects.get(module_bay=module_bay_2)
module_3 = Module.objects.get(module_bay=module_bay_3)
# Confirm error if ModuleBay recurses
@@ -681,8 +679,6 @@ class ModuleBayTestCase(TestCase):
module_1.save()
def test_single_module_token(self):
- module_bays = ModuleBay.objects.all()
- modules = Module.objects.all()
device_type = DeviceType.objects.first()
device_role = DeviceRole.objects.first()
site = Site.objects.first()
@@ -708,7 +704,7 @@ class ModuleBayTestCase(TestCase):
location=location,
rack=rack
)
- cp = device.consoleports.first()
+ device.consoleports.first()
def test_nested_module_token(self):
pass
@@ -733,39 +729,41 @@ class CableTestCase(TestCase):
device2 = Device.objects.create(
device_type=devicetype, role=role, name='TestDevice2', site=site
)
- interface1 = Interface.objects.create(device=device1, name='eth0')
- interface2 = Interface.objects.create(device=device2, name='eth0')
- interface3 = Interface.objects.create(device=device2, name='eth1')
- Cable(a_terminations=[interface1], b_terminations=[interface2]).save()
+ interfaces = (
+ Interface(device=device1, name='eth0'),
+ Interface(device=device2, name='eth0'),
+ Interface(device=device2, name='eth1'),
+ )
+ Interface.objects.bulk_create(interfaces)
+ Cable(a_terminations=[interfaces[0]], b_terminations=[interfaces[1]]).save()
+ PowerPort.objects.create(device=device2, name='psu1')
- power_port1 = PowerPort.objects.create(device=device2, name='psu1')
- patch_pannel = Device.objects.create(
+ patch_panel = Device.objects.create(
device_type=devicetype, role=role, name='TestPatchPanel', site=site
)
- rear_port1 = RearPort.objects.create(device=patch_pannel, name='RP1', type='8p8c')
- front_port1 = FrontPort.objects.create(
- device=patch_pannel, name='FP1', type='8p8c', rear_port=rear_port1, rear_port_position=1
+ rear_ports = (
+ RearPort(device=patch_panel, name='RP1', type='8p8c'),
+ RearPort(device=patch_panel, name='RP2', type='8p8c', positions=2),
+ RearPort(device=patch_panel, name='RP3', type='8p8c', positions=3),
+ RearPort(device=patch_panel, name='RP4', type='8p8c', positions=3),
)
- rear_port2 = RearPort.objects.create(device=patch_pannel, name='RP2', type='8p8c', positions=2)
- front_port2 = FrontPort.objects.create(
- device=patch_pannel, name='FP2', type='8p8c', rear_port=rear_port2, rear_port_position=1
- )
- rear_port3 = RearPort.objects.create(device=patch_pannel, name='RP3', type='8p8c', positions=3)
- front_port3 = FrontPort.objects.create(
- device=patch_pannel, name='FP3', type='8p8c', rear_port=rear_port3, rear_port_position=1
- )
- rear_port4 = RearPort.objects.create(device=patch_pannel, name='RP4', type='8p8c', positions=3)
- front_port4 = FrontPort.objects.create(
- device=patch_pannel, name='FP4', type='8p8c', rear_port=rear_port4, rear_port_position=1
+ RearPort.objects.bulk_create(rear_ports)
+ front_ports = (
+ FrontPort(device=patch_panel, name='FP1', type='8p8c', rear_port=rear_ports[0], rear_port_position=1),
+ FrontPort(device=patch_panel, name='FP2', type='8p8c', rear_port=rear_ports[1], rear_port_position=1),
+ FrontPort(device=patch_panel, name='FP3', type='8p8c', rear_port=rear_ports[2], rear_port_position=1),
+ FrontPort(device=patch_panel, name='FP4', type='8p8c', rear_port=rear_ports[3], rear_port_position=1),
)
+ FrontPort.objects.bulk_create(front_ports)
+
provider = Provider.objects.create(name='Provider 1', slug='provider-1')
provider_network = ProviderNetwork.objects.create(name='Provider Network 1', provider=provider)
circuittype = CircuitType.objects.create(name='Circuit Type 1', slug='circuit-type-1')
circuit1 = Circuit.objects.create(provider=provider, type=circuittype, cid='1')
circuit2 = Circuit.objects.create(provider=provider, type=circuittype, cid='2')
- circuittermination1 = CircuitTermination.objects.create(circuit=circuit1, site=site, term_side='A')
- circuittermination2 = CircuitTermination.objects.create(circuit=circuit1, site=site, term_side='Z')
- circuittermination3 = CircuitTermination.objects.create(circuit=circuit2, provider_network=provider_network, term_side='A')
+ CircuitTermination.objects.create(circuit=circuit1, site=site, term_side='A')
+ CircuitTermination.objects.create(circuit=circuit1, site=site, term_side='Z')
+ CircuitTermination.objects.create(circuit=circuit2, provider_network=provider_network, term_side='A')
def test_cable_creation(self):
"""
diff --git a/netbox/extras/tests/test_models.py b/netbox/extras/tests/test_models.py
index c92a1bc54..188a06a3f 100644
--- a/netbox/extras/tests/test_models.py
+++ b/netbox/extras/tests/test_models.py
@@ -49,11 +49,11 @@ class ConfigContextTest(TestCase):
sitegroup = SiteGroup.objects.create(name='Site Group')
site = Site.objects.create(name='Site 1', slug='site-1', region=region, group=sitegroup)
location = Location.objects.create(name='Location 1', slug='location-1', site=site)
- platform = Platform.objects.create(name='Platform')
+ Platform.objects.create(name='Platform')
tenantgroup = TenantGroup.objects.create(name='Tenant Group')
- tenant = Tenant.objects.create(name='Tenant', group=tenantgroup)
- tag1 = Tag.objects.create(name='Tag', slug='tag')
- tag2 = Tag.objects.create(name='Tag2', slug='tag2')
+ Tenant.objects.create(name='Tenant', group=tenantgroup)
+ Tag.objects.create(name='Tag', slug='tag')
+ Tag.objects.create(name='Tag2', slug='tag2')
Device.objects.create(
name='Device 1',
diff --git a/netbox/ipam/tests/test_api.py b/netbox/ipam/tests/test_api.py
index 59335cbbe..1d2cdf1b7 100644
--- a/netbox/ipam/tests/test_api.py
+++ b/netbox/ipam/tests/test_api.py
@@ -700,8 +700,6 @@ class IPAddressTest(APIViewTestCases.APIViewTestCase):
device1.primary_ip4 = ip_addresses[0]
device1.save()
- ip2 = ip_addresses[1]
-
url = reverse('ipam-api:ipaddress-detail', kwargs={'pk': ip1.pk})
self.add_permissions('ipam.change_ipaddress')
diff --git a/netbox/netbox/settings.py b/netbox/netbox/settings.py
index 9c5078ccb..a8ac68d4d 100644
--- a/netbox/netbox/settings.py
+++ b/netbox/netbox/settings.py
@@ -198,7 +198,7 @@ if len(SECRET_KEY) < 50:
if RELEASE_CHECK_URL:
try:
URLValidator()(RELEASE_CHECK_URL)
- except ValidationError as e:
+ except ValidationError:
raise ImproperlyConfigured(
"RELEASE_CHECK_URL must be a valid URL. Example: https://api.github.com/repos/netbox-community/netbox"
)
diff --git a/netbox/netbox/tests/test_authentication.py b/netbox/netbox/tests/test_authentication.py
index 5c7a30dc7..ae6d3f4c2 100644
--- a/netbox/netbox/tests/test_authentication.py
+++ b/netbox/netbox/tests/test_authentication.py
@@ -106,7 +106,7 @@ class ExternalAuthenticationTestCase(TestCase):
self.assertEqual(settings.REMOTE_AUTH_HEADER, 'HTTP_REMOTE_USER')
# Client should not be authenticated
- response = self.client.get(reverse('home'), follow=True, **headers)
+ self.client.get(reverse('home'), follow=True, **headers)
self.assertNotIn('_auth_user_id', self.client.session)
@override_settings(
diff --git a/netbox/netbox/tests/test_import.py b/netbox/netbox/tests/test_import.py
index 03690029c..16711ef72 100644
--- a/netbox/netbox/tests/test_import.py
+++ b/netbox/netbox/tests/test_import.py
@@ -77,7 +77,6 @@ class CSVImportTestCase(ModelViewTestCase):
self.assertHttpStatus(self.client.post(self._get_url('import'), data), 302)
regions = Region.objects.all()
self.assertEqual(regions.count(), 4)
- region = Region.objects.get(slug="region-4")
self.assertEqual(
list(regions[0].tags.values_list('name', flat=True)),
['Alpha', 'Bravo']
diff --git a/netbox/users/forms/model_forms.py b/netbox/users/forms/model_forms.py
index 639b9f726..42c3b15f0 100644
--- a/netbox/users/forms/model_forms.py
+++ b/netbox/users/forms/model_forms.py
@@ -36,7 +36,6 @@ class UserConfigFormMetaclass(forms.models.ModelFormMetaclass):
# Emulate a declared field for each supported user preference
preference_fields = {}
for field_name, preference in PREFERENCES.items():
- description = f'{preference.description}
' if preference.description else ''
help_text = f'{field_name}
'
if preference.description:
help_text = f'{preference.description}
{help_text}'
diff --git a/netbox/utilities/html.py b/netbox/utilities/html.py
index f99dabe5a..c9203d169 100644
--- a/netbox/utilities/html.py
+++ b/netbox/utilities/html.py
@@ -59,7 +59,7 @@ def highlight(value, highlight, trim_pre=None, trim_post=None, trim_placeholder=
else:
highlight = re.escape(highlight)
pre, match, post = re.split(fr'({highlight})', value, maxsplit=1, flags=re.IGNORECASE)
- except ValueError as e:
+ except ValueError:
# Match not found
return escape(value)
diff --git a/netbox/utilities/tests/test_counters.py b/netbox/utilities/tests/test_counters.py
index b87e73ace..45823065e 100644
--- a/netbox/utilities/tests/test_counters.py
+++ b/netbox/utilities/tests/test_counters.py
@@ -85,7 +85,7 @@ class CountersTest(TestCase):
def test_mptt_child_delete(self):
device1, device2 = Device.objects.all()
inventory_item1 = InventoryItem.objects.create(device=device1, name='Inventory Item 1')
- inventory_item2 = InventoryItem.objects.create(device=device1, name='Inventory Item 2', parent=inventory_item1)
+ InventoryItem.objects.create(device=device1, name='Inventory Item 2', parent=inventory_item1)
device1.refresh_from_db()
self.assertEqual(device1.inventory_item_count, 2)