From f32f2ed1f30377f7fbe36f832427d6c607b5147a Mon Sep 17 00:00:00 2001 From: Jeremy Stretch Date: Tue, 25 Jun 2024 08:49:07 -0400 Subject: [PATCH] Misc cleanup --- netbox/netbox/middleware.py | 1 - netbox/utilities/views.py | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/netbox/netbox/middleware.py b/netbox/netbox/middleware.py index 98dfeb3fd..3d94734ee 100644 --- a/netbox/netbox/middleware.py +++ b/netbox/netbox/middleware.py @@ -1,6 +1,5 @@ import logging import uuid -from urllib import parse from django.conf import settings from django.contrib import auth, messages diff --git a/netbox/utilities/views.py b/netbox/utilities/views.py index a68c98e96..f7181ea92 100644 --- a/netbox/utilities/views.py +++ b/netbox/utilities/views.py @@ -31,7 +31,7 @@ __all__ = ( class ConditionalLoginRequiredMixin(AccessMixin): """ - Requires a user to be authenticated if LOGIN_REQUIRED is True. + Similar to Django's LoginRequiredMixin, but enforces authentication only if LOGIN_REQUIRED is True. """ def dispatch(self, request, *args, **kwargs): if settings.LOGIN_REQUIRED and not request.user.is_authenticated: @@ -42,7 +42,7 @@ class ConditionalLoginRequiredMixin(AccessMixin): class ContentTypePermissionRequiredMixin(ConditionalLoginRequiredMixin): """ Similar to Django's built-in PermissionRequiredMixin, but extended to check model-level permission assignments. - This is related to ObjectPermissionRequiredMixin, except that is does not enforce object-level permissions, + This is related to ObjectPermissionRequiredMixin, except that it does not enforce object-level permissions, and fits within NetBox's custom permission enforcement system. additional_permissions: An optional iterable of statically declared permissions to evaluate in addition to those