NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-23 17:08:41 -06:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

Fixes #6640: Disallow numeric values in custom text fields

Browse Source
This commit is contained in:
jeremystretch 2021-06-22 14:00:54 -04:00
parent ebb2918a88
commit efa0fc2b09
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/release-notes/version-2.11.md
View File

@ -5,6 +5,7 @@
### Bug Fixes ### Bug Fixes
* [#6626](https://github.com/netbox-community/netbox/issues/6626) - Fix site field on VM search form; add site group * [#6626](https://github.com/netbox-community/netbox/issues/6626) - Fix site field on VM search form; add site group
* [#6640](https://github.com/netbox-community/netbox/issues/6640) - Disallow numeric values in custom text fields
* [#6652](https://github.com/netbox-community/netbox/issues/6652) - Fix exception when adding components in bulk to multiple devices * [#6652](https://github.com/netbox-community/netbox/issues/6652) - Fix exception when adding components in bulk to multiple devices
--- ---

6
netbox/extras/models/customfields.py
View File

@ -280,8 +280,10 @@ class CustomField(BigIDModel):
if value not in [None, '']: if value not in [None, '']:
# Validate text field # Validate text field
if self.type == CustomFieldTypeChoices.TYPE_TEXT and self.validation_regex: if self.type == CustomFieldTypeChoices.TYPE_TEXT:
if not re.match(self.validation_regex, value): if type(value) is not str:
raise ValidationError(f"Value must be a string.")
if self.validation_regex and not re.match(self.validation_regex, value):
raise ValidationError(f"Value must match regex '{self.validation_regex}'") raise ValidationError(f"Value must match regex '{self.validation_regex}'")
# Validate integer # Validate integer