From ef0b455b05ca50746c09017c5adea21156628169 Mon Sep 17 00:00:00 2001 From: kkthxbye-code Date: Sun, 9 Oct 2022 21:16:26 +0200 Subject: [PATCH] Called super delete method before deleting JobResult task. Done to avoid having deleted a task on accident if the deleting of the JobResult fails. --- netbox/extras/models/models.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/netbox/extras/models/models.py b/netbox/extras/models/models.py index 2d3df5ca2..e81c58136 100644 --- a/netbox/extras/models/models.py +++ b/netbox/extras/models/models.py @@ -534,14 +534,14 @@ class JobResult(models.Model): return str(self.job_id) def delete(self, *args, **kwargs): + super().delete(*args, **kwargs) + queue = django_rq.get_queue("default") job = queue.fetch_job(str(self.job_id)) if job: job.cancel() - return super().delete(*args, **kwargs) - def get_absolute_url(self): return reverse(f'extras:{self.obj_type.name}_result', args=[self.pk])