mirror of
https://github.com/netbox-community/netbox.git
synced 2025-08-26 17:26:10 -06:00
applied suggestion
This commit is contained in:
parent
5aae5a68f2
commit
ee2b4b4aac
@ -67,22 +67,23 @@ class NetBoxModel(CloningMixin, NetBoxFeatureSet, models.Model):
|
|||||||
|
|
||||||
for field in self._meta.get_fields():
|
for field in self._meta.get_fields():
|
||||||
if isinstance(field, GenericForeignKey):
|
if isinstance(field, GenericForeignKey):
|
||||||
if getattr(self, field.ct_field) is None and getattr(self, field.fk_field) is not None:
|
ct_field = getattr(self, field.ct_field)
|
||||||
|
fk_field = getattr(self, field.fk_field)
|
||||||
|
|
||||||
|
if ct_field is None and fk_field is not None:
|
||||||
raise ValidationError({
|
raise ValidationError({
|
||||||
field.ct_field: "This field cannot be null.",
|
field.ct_field: "This field cannot be null.",
|
||||||
})
|
})
|
||||||
if getattr(self, field.fk_field) is None and getattr(self, field.ct_field) is not None:
|
if fk_field is None and ct_field is not None:
|
||||||
raise ValidationError({
|
raise ValidationError({
|
||||||
field.fk_field: "This field cannot be null.",
|
field.fk_field: "This field cannot be null.",
|
||||||
})
|
})
|
||||||
|
|
||||||
if getattr(self, field.ct_field) and getattr(self, field.fk_field):
|
if ct_field and fk_field:
|
||||||
klass = getattr(self, field.ct_field).model_class()
|
klass = getattr(self, field.ct_field).model_class()
|
||||||
try:
|
if not klass.objects.filter(pk=fk_field).exists():
|
||||||
klass.objects.get(pk=getattr(self, field.fk_field))
|
|
||||||
except klass.DoesNotExist:
|
|
||||||
raise ValidationError({
|
raise ValidationError({
|
||||||
field.fk_field: f"Invalid {getattr(self, field.fk_field)}: object does not exist on {getattr(self, field.ct_field)}."
|
field.fk_field: f"Invalid {fk_field}: object does not exist on {ct_field}."
|
||||||
})
|
})
|
||||||
|
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user