From edb7d24b458b60fa82b16bc37e79f37821e3685f Mon Sep 17 00:00:00 2001 From: Abhimanyu Saharan Date: Fri, 23 Feb 2024 12:54:47 -0800 Subject: [PATCH] Added installed_module on NestedModuleBaySerializer (#15245) * added installed_module on NestedModuleBaySerializer #15243 * Update test --------- Co-authored-by: Jeremy Stretch --- netbox/dcim/api/nested_serializers.py | 4 ++-- netbox/dcim/api/serializers.py | 3 +-- netbox/dcim/tests/test_api.py | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/netbox/dcim/api/nested_serializers.py b/netbox/dcim/api/nested_serializers.py index c8440612d..419d9b175 100644 --- a/netbox/dcim/api/nested_serializers.py +++ b/netbox/dcim/api/nested_serializers.py @@ -414,11 +414,11 @@ class NestedFrontPortSerializer(WritableNestedSerializer): class NestedModuleBaySerializer(WritableNestedSerializer): url = serializers.HyperlinkedIdentityField(view_name='dcim-api:modulebay-detail') - module = NestedModuleSerializer(required=False, read_only=True, allow_null=True) + installed_module = ModuleBayNestedModuleSerializer(required=False, allow_null=True) class Meta: model = models.ModuleBay - fields = ['id', 'url', 'display', 'module', 'name'] + fields = ['id', 'url', 'display', 'installed_module', 'name'] class NestedDeviceBaySerializer(WritableNestedSerializer): diff --git a/netbox/dcim/api/serializers.py b/netbox/dcim/api/serializers.py index f8541f013..ab3177de5 100644 --- a/netbox/dcim/api/serializers.py +++ b/netbox/dcim/api/serializers.py @@ -1039,8 +1039,7 @@ class ModuleBaySerializer(NetBoxModelSerializer): model = ModuleBay fields = [ 'id', 'url', 'display', 'device', 'name', 'installed_module', 'label', 'position', 'description', 'tags', - 'custom_fields', - 'created', 'last_updated', + 'custom_fields', 'created', 'last_updated', ] diff --git a/netbox/dcim/tests/test_api.py b/netbox/dcim/tests/test_api.py index d02422c6f..b0670fdff 100644 --- a/netbox/dcim/tests/test_api.py +++ b/netbox/dcim/tests/test_api.py @@ -1755,7 +1755,7 @@ class RearPortTest(APIViewTestCases.APIViewTestCase): class ModuleBayTest(APIViewTestCases.APIViewTestCase): model = ModuleBay - brief_fields = ['display', 'id', 'module', 'name', 'url'] + brief_fields = ['display', 'id', 'installed_module', 'name', 'url'] bulk_update_data = { 'description': 'New description', }