16546 define get_absolute_url method in NetBoxModel (#17693)

* 16546 define get_absolute_url method in NetBoxModel

* 16546 define get_absolute_url method in NetBoxModel

* 16546 define get_absolute_url method in NetBoxModel

* 16546 move get_absolute_url to NetBoxFeatureSet

* 16546 fix CircuitTermination

* Fix linebreaks

---------

Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>

netbox/dcim/models/cables.py

@@ -116,9 +116,6 @@ class Cable(PrimaryModel):
         pk = self.pk or self._pk
         return self.label or f'#{pk}'
 
-    def get_absolute_url(self):
-        return reverse('dcim:cable', args=[self.pk])
-
     @property
     def a_terminations(self):
         if hasattr(self, '_a_terminations'):

netbox/dcim/models/device_components.py

@@ -301,9 +301,6 @@ class ConsolePort(ModularComponentModel, CabledObjectModel, PathEndpoint, Tracki
         verbose_name = _('console port')
         verbose_name_plural = _('console ports')
 
-    def get_absolute_url(self):
-        return reverse('dcim:consoleport', kwargs={'pk': self.pk})
-
 
 class ConsoleServerPort(ModularComponentModel, CabledObjectModel, PathEndpoint, TrackingModelMixin):
     """
@@ -330,9 +327,6 @@ class ConsoleServerPort(ModularComponentModel, CabledObjectModel, PathEndpoint,
         verbose_name = _('console server port')
         verbose_name_plural = _('console server ports')
 
-    def get_absolute_url(self):
-        return reverse('dcim:consoleserverport', kwargs={'pk': self.pk})
-
 
 #
 # Power components
@@ -370,9 +364,6 @@ class PowerPort(ModularComponentModel, CabledObjectModel, PathEndpoint, Tracking
         verbose_name = _('power port')
         verbose_name_plural = _('power ports')
 
-    def get_absolute_url(self):
-        return reverse('dcim:powerport', kwargs={'pk': self.pk})
-
     def clean(self):
         super().clean()
 
@@ -492,9 +483,6 @@ class PowerOutlet(ModularComponentModel, CabledObjectModel, PathEndpoint, Tracki
         verbose_name = _('power outlet')
         verbose_name_plural = _('power outlets')
 
-    def get_absolute_url(self):
-        return reverse('dcim:poweroutlet', kwargs={'pk': self.pk})
-
     def clean(self):
         super().clean()
 
@@ -750,9 +738,6 @@ class Interface(ModularComponentModel, BaseInterface, CabledObjectModel, PathEnd
         verbose_name = _('interface')
         verbose_name_plural = _('interfaces')
 
-    def get_absolute_url(self):
-        return reverse('dcim:interface', kwargs={'pk': self.pk})
-
     def clean(self):
         super().clean()
 
@@ -1011,9 +996,6 @@ class FrontPort(ModularComponentModel, CabledObjectModel, TrackingModelMixin):
         verbose_name = _('front port')
         verbose_name_plural = _('front ports')
 
-    def get_absolute_url(self):
-        return reverse('dcim:frontport', kwargs={'pk': self.pk})
-
     def clean(self):
         super().clean()
 
@@ -1069,9 +1051,6 @@ class RearPort(ModularComponentModel, CabledObjectModel, TrackingModelMixin):
         verbose_name = _('rear port')
         verbose_name_plural = _('rear ports')
 
-    def get_absolute_url(self):
-        return reverse('dcim:rearport', kwargs={'pk': self.pk})
-
     def clean(self):
         super().clean()
 
@@ -1128,9 +1107,6 @@ class ModuleBay(ModularComponentModel, TrackingModelMixin, MPTTModel):
     class MPTTMeta:
         order_insertion_by = ('module',)
 
-    def get_absolute_url(self):
-        return reverse('dcim:modulebay', kwargs={'pk': self.pk})
-
     def clean(self):
         super().clean()
 
@@ -1169,9 +1145,6 @@ class DeviceBay(ComponentModel, TrackingModelMixin):
         verbose_name = _('device bay')
         verbose_name_plural = _('device bays')
 
-    def get_absolute_url(self):
-        return reverse('dcim:devicebay', kwargs={'pk': self.pk})
-
     def clean(self):
         super().clean()
 
@@ -1215,9 +1188,6 @@ class InventoryItemRole(OrganizationalModel):
         verbose_name = _('inventory item role')
         verbose_name_plural = _('inventory item roles')
 
-    def get_absolute_url(self):
-        return reverse('dcim:inventoryitemrole', args=[self.pk])
-
 
 class InventoryItem(MPTTModel, ComponentModel, TrackingModelMixin):
     """
@@ -1311,9 +1281,6 @@ class InventoryItem(MPTTModel, ComponentModel, TrackingModelMixin):
         verbose_name = _('inventory item')
         verbose_name_plural = _('inventory items')
 
-    def get_absolute_url(self):
-        return reverse('dcim:inventoryitem', kwargs={'pk': self.pk})
-
     def clean(self):
         super().clean()
 

netbox/dcim/models/devices.py

@@ -54,9 +54,6 @@ class Manufacturer(ContactsMixin, OrganizationalModel):
         verbose_name = _('manufacturer')
         verbose_name_plural = _('manufacturers')
 
-    def get_absolute_url(self):
-        return reverse('dcim:manufacturer', args=[self.pk])
-
 
 class DeviceType(ImageAttachmentsMixin, PrimaryModel, WeightMixin):
     """
@@ -217,9 +214,6 @@ class DeviceType(ImageAttachmentsMixin, PrimaryModel, WeightMixin):
         self._original_front_image = self.__dict__.get('front_image')
         self._original_rear_image = self.__dict__.get('rear_image')
 
-    def get_absolute_url(self):
-        return reverse('dcim:devicetype', args=[self.pk])
-
     @property
     def full_name(self):
         return f"{self.manufacturer} {self.model}"
@@ -414,9 +408,6 @@ class ModuleType(ImageAttachmentsMixin, PrimaryModel, WeightMixin):
     def __str__(self):
         return self.model
 
-    def get_absolute_url(self):
-        return reverse('dcim:moduletype', args=[self.pk])
-
     @property
     def full_name(self):
         return f"{self.manufacturer} {self.model}"
@@ -497,9 +488,6 @@ class DeviceRole(OrganizationalModel):
         verbose_name = _('device role')
         verbose_name_plural = _('device roles')
 
-    def get_absolute_url(self):
-        return reverse('dcim:devicerole', args=[self.pk])
-
 
 class Platform(OrganizationalModel):
     """
@@ -527,9 +515,6 @@ class Platform(OrganizationalModel):
         verbose_name = _('platform')
         verbose_name_plural = _('platforms')
 
-    def get_absolute_url(self):
-        return reverse('dcim:platform', args=[self.pk])
-
 
 def update_interface_bridges(device, interface_templates, module=None):
     """
@@ -823,9 +808,6 @@ class Device(
             return f'{self.device_type.manufacturer} {self.device_type.model} ({self.pk})'
         return super().__str__()
 
-    def get_absolute_url(self):
-        return reverse('dcim:device', args=[self.pk])
-
     def clean(self):
         super().clean()
 
@@ -1192,9 +1174,6 @@ class Module(PrimaryModel, ConfigContextModel):
     def __str__(self):
         return f'{self.module_bay.name}: {self.module_type} ({self.pk})'
 
-    def get_absolute_url(self):
-        return reverse('dcim:module', args=[self.pk])
-
     def get_status_color(self):
         return ModuleStatusChoices.colors.get(self.status)
 
@@ -1343,9 +1322,6 @@ class VirtualChassis(PrimaryModel):
     def __str__(self):
         return self.name
 
-    def get_absolute_url(self):
-        return reverse('dcim:virtualchassis', kwargs={'pk': self.pk})
-
     def clean(self):
         super().clean()
 
@@ -1445,9 +1421,6 @@ class VirtualDeviceContext(PrimaryModel):
     def __str__(self):
         return self.name
 
-    def get_absolute_url(self):
-        return reverse('dcim:virtualdevicecontext', kwargs={'pk': self.pk})
-
     def get_status_color(self):
         return VirtualDeviceContextStatusChoices.colors.get(self.status)
 

netbox/dcim/models/power.py

@@ -58,9 +58,6 @@ class PowerPanel(ContactsMixin, ImageAttachmentsMixin, PrimaryModel):
     def __str__(self):
         return self.name
 
-    def get_absolute_url(self):
-        return reverse('dcim:powerpanel', args=[self.pk])
-
     def clean(self):
         super().clean()
 
@@ -167,9 +164,6 @@ class PowerFeed(PrimaryModel, PathEndpoint, CabledObjectModel):
     def __str__(self):
         return self.name
 
-    def get_absolute_url(self):
-        return reverse('dcim:powerfeed', args=[self.pk])
-
     def clean(self):
         super().clean()
 

netbox/dcim/models/racks.py

@@ -165,9 +165,6 @@ class RackType(RackBase):
     def __str__(self):
         return self.model
 
-    def get_absolute_url(self):
-        return reverse('dcim:racktype', args=[self.pk])
-
     @property
     def full_name(self):
         return f"{self.manufacturer} {self.model}"
@@ -230,9 +227,6 @@ class RackRole(OrganizationalModel):
         verbose_name = _('rack role')
         verbose_name_plural = _('rack roles')
 
-    def get_absolute_url(self):
-        return reverse('dcim:rackrole', args=[self.pk])
-
 
 class Rack(ContactsMixin, ImageAttachmentsMixin, RackBase):
     """
@@ -364,9 +358,6 @@ class Rack(ContactsMixin, ImageAttachmentsMixin, RackBase):
             return f'{self.name} ({self.facility_id})'
         return self.name
 
-    def get_absolute_url(self):
-        return reverse('dcim:rack', args=[self.pk])
-
     def clean(self):
         super().clean()
 
@@ -699,9 +690,6 @@ class RackReservation(PrimaryModel):
     def __str__(self):
         return "Reservation for rack {}".format(self.rack)
 
-    def get_absolute_url(self):
-        return reverse('dcim:rackreservation', args=[self.pk])
-
     def clean(self):
         super().clean()
 

netbox/dcim/models/sites.py

@@ -62,9 +62,6 @@ class Region(ContactsMixin, NestedGroupModel):
         verbose_name = _('region')
         verbose_name_plural = _('regions')
 
-    def get_absolute_url(self):
-        return reverse('dcim:region', args=[self.pk])
-
     def get_site_count(self):
         return Site.objects.filter(
             Q(region=self) |
@@ -115,9 +112,6 @@ class SiteGroup(ContactsMixin, NestedGroupModel):
         verbose_name = _('site group')
         verbose_name_plural = _('site groups')
 
-    def get_absolute_url(self):
-        return reverse('dcim:sitegroup', args=[self.pk])
-
     def get_site_count(self):
         return Site.objects.filter(
             Q(group=self) |
@@ -241,9 +235,6 @@ class Site(ContactsMixin, ImageAttachmentsMixin, PrimaryModel):
     def __str__(self):
         return self.name
 
-    def get_absolute_url(self):
-        return reverse('dcim:site', args=[self.pk])
-
     def get_status_color(self):
         return SiteStatusChoices.colors.get(self.status)
 
@@ -322,9 +313,6 @@ class Location(ContactsMixin, ImageAttachmentsMixin, NestedGroupModel):
         verbose_name = _('location')
         verbose_name_plural = _('locations')
 
-    def get_absolute_url(self):
-        return reverse('dcim:location', args=[self.pk])
-
     def get_status_color(self):
         return LocationStatusChoices.colors.get(self.status)