NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-08-18 05:28:16 -06:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Fix test to check for PK

Browse Source
This commit is contained in:
Daniel Sheppard 2023-12-21 14:39:56 -06:00
parent 9374890724
commit ec58b5338f
1 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
netbox/ipam/forms/model_forms.py
View File

@ -369,17 +369,18 @@ class IPAddressForm(TenancyForm, NetBoxModelForm):
'primary_for_parent', _("Only IP addresses assigned to an interface can be designated as primary IPs.")
)
prev_interface = self.instance.interface.first() or self.instance.vminterface.first()
# If the prev interface exists and does not match the new interface, we need to validate it isn't set as primary
# for the parent
if prev_interface and prev_interface != interface:
prev_parent = prev_interface.device or prev_interface.virtual_machine
# Check that the parent exists and if it is set as a primary ip.
if prev_parent and prev_parent.primary_ip4 == self.instance or prev_parent.primary_ip6 == self.instance:
self.add_error(
selected_objects[0],
_("Cannot reassign IP address while it is designated as the primary IP for the parent object")
)
if self.instance.pk:
prev_interface = self.instance.interface.first() or self.instance.vminterface.first()
# If the prev interface exists and does not match the new interface, we need to validate it isn't set as primary
# for the parent
if prev_interface and prev_interface != interface:
prev_parent = prev_interface.device or prev_interface.virtual_machine
# Check that the parent exists and if it is set as a primary ip.
if prev_parent and prev_parent.primary_ip4 == self.instance or prev_parent.primary_ip6 == self.instance:
self.add_error(
selected_objects[0],
_("Cannot reassign IP address while it is designated as the primary IP for the parent object")
)
# Do not allow assigning a network ID or broadcast address to an interface.
if interface and (address := self.cleaned_data.get('address')):