From e828ca5cb42fa32ad7fb01537941a8bc6b5f4fc1 Mon Sep 17 00:00:00 2001 From: Jeremy Stretch Date: Wed, 6 Aug 2025 16:49:52 -0400 Subject: [PATCH] Fixes #20030: Fix height of object list action buttons & others (#20036) --- netbox/netbox/tables/columns.py | 6 +++++- netbox/templates/circuits/inc/circuit_termination.html | 10 +++++----- .../circuits/inc/circuit_termination_fields.html | 6 +++--- netbox/templates/dcim/frontport.html | 2 +- netbox/templates/dcim/inc/cable_termination.html | 6 +++--- netbox/templates/dcim/inc/connection_endpoints.html | 2 +- netbox/templates/dcim/inc/panels/inventory_items.html | 4 ++-- netbox/templates/dcim/interface.html | 2 +- netbox/templates/dcim/rearport.html | 2 +- netbox/templates/extras/htmx/script_result.html | 2 +- netbox/templates/extras/object_render_config.html | 6 +++--- netbox/templates/ipam/inc/panels/fhrp_groups.html | 4 ++-- 12 files changed, 28 insertions(+), 24 deletions(-) diff --git a/netbox/netbox/tables/columns.py b/netbox/netbox/tables/columns.py index 3d36ec8f8..c13a8333b 100644 --- a/netbox/netbox/tables/columns.py +++ b/netbox/netbox/tables/columns.py @@ -237,7 +237,11 @@ class ActionsColumn(tables.Column): :param split_actions: When True, converts the actions dropdown menu into a split button with first action as the direct button link and icon (default: True) """ - attrs = {'td': {'class': 'text-end text-nowrap noprint'}} + attrs = { + 'td': { + 'class': 'text-end text-nowrap noprint p-1' + } + } empty_values = () actions = { 'edit': ActionsItem('Edit', 'pencil', 'change', 'warning'), diff --git a/netbox/templates/circuits/inc/circuit_termination.html b/netbox/templates/circuits/inc/circuit_termination.html index 49c23e885..365f006ab 100644 --- a/netbox/templates/circuits/inc/circuit_termination.html +++ b/netbox/templates/circuits/inc/circuit_termination.html @@ -4,22 +4,22 @@

{% blocktrans %}Termination{% endblocktrans %} {{ side }} -
+
{% if not termination and perms.circuits.add_circuittermination %} - + {% trans "Add" %} {% endif %} {% if termination and perms.circuits.change_circuittermination %} - + {% trans "Edit" %} - + {% trans "Swap" %} {% endif %} {% if termination and perms.circuits.delete_circuittermination %} - + {% trans "Delete" %} {% endif %} diff --git a/netbox/templates/circuits/inc/circuit_termination_fields.html b/netbox/templates/circuits/inc/circuit_termination_fields.html index ea5bab7ae..efe30e28e 100644 --- a/netbox/templates/circuits/inc/circuit_termination_fields.html +++ b/netbox/templates/circuits/inc/circuit_termination_fields.html @@ -29,16 +29,16 @@ {{ peer|linkify }}{% if not forloop.last %},{% endif %} {% endfor %}
- + {% trans "Trace" %} {% if perms.dcim.change_cable %} - + {% trans "Edit" %} {% endif %} {% if perms.dcim.delete_cable %} - + {% trans "Disconnect" %} {% endif %} diff --git a/netbox/templates/dcim/frontport.html b/netbox/templates/dcim/frontport.html index 163ccbc8e..9f4d23e60 100644 --- a/netbox/templates/dcim/frontport.html +++ b/netbox/templates/dcim/frontport.html @@ -77,7 +77,7 @@ {% trans "Cable" %} {{ object.cable|linkify }} - + diff --git a/netbox/templates/dcim/inc/cable_termination.html b/netbox/templates/dcim/inc/cable_termination.html index 1284bc420..e29a630e0 100644 --- a/netbox/templates/dcim/inc/cable_termination.html +++ b/netbox/templates/dcim/inc/cable_termination.html @@ -24,7 +24,7 @@ {{ term|linkify }} {% with trace_url=term|viewname:"trace" %} - + {% endwith %} @@ -48,7 +48,7 @@ {% for term in terminations %} {{ term|linkify }} {% with trace_url=term|viewname:"trace" %} - + {% endwith %} @@ -68,7 +68,7 @@ {% for term in terminations %} {{ term.circuit|linkify }} ({{ term }}) {% with trace_url=term|viewname:"trace" %} - + {% endwith %} diff --git a/netbox/templates/dcim/inc/connection_endpoints.html b/netbox/templates/dcim/inc/connection_endpoints.html index bc1da5489..6223e70c9 100644 --- a/netbox/templates/dcim/inc/connection_endpoints.html +++ b/netbox/templates/dcim/inc/connection_endpoints.html @@ -4,7 +4,7 @@ {% trans "Cable" %} {{ object.cable|linkify }} - + diff --git a/netbox/templates/dcim/inc/panels/inventory_items.html b/netbox/templates/dcim/inc/panels/inventory_items.html index aea5eae16..ff49d1a53 100644 --- a/netbox/templates/dcim/inc/panels/inventory_items.html +++ b/netbox/templates/dcim/inc/panels/inventory_items.html @@ -29,12 +29,12 @@ {{ item.role|linkify|placeholder }} {% if perms.dcim.change_inventoryitem %} - + {% endif %} {% if perms.ipam.delete_inventoryitem %} - + {% endif %} diff --git a/netbox/templates/dcim/interface.html b/netbox/templates/dcim/interface.html index 134c4e364..f6e34e355 100644 --- a/netbox/templates/dcim/interface.html +++ b/netbox/templates/dcim/interface.html @@ -208,7 +208,7 @@ {% trans "Wireless Link" %} {{ object.wireless_link|linkify }} - + diff --git a/netbox/templates/dcim/rearport.html b/netbox/templates/dcim/rearport.html index 8aa0a5dfe..3fed4307b 100644 --- a/netbox/templates/dcim/rearport.html +++ b/netbox/templates/dcim/rearport.html @@ -73,7 +73,7 @@ {% trans "Cable" %} {{ object.cable|linkify }} - + diff --git a/netbox/templates/extras/htmx/script_result.html b/netbox/templates/extras/htmx/script_result.html index e6b4d1823..ac5d87ef2 100644 --- a/netbox/templates/extras/htmx/script_result.html +++ b/netbox/templates/extras/htmx/script_result.html @@ -57,7 +57,7 @@ {% trans "Output" %} {% if job.completed %} diff --git a/netbox/templates/extras/object_render_config.html b/netbox/templates/extras/object_render_config.html index 10d6d4aef..aec25cd64 100644 --- a/netbox/templates/extras/object_render_config.html +++ b/netbox/templates/extras/object_render_config.html @@ -54,11 +54,11 @@

{% trans "Rendered Config" %} -
- {% copy_content "rendered_config" %} - +
+ {% trans "Download" %} + {% copy_content "rendered_config" %}

{{ rendered_config }}
diff --git a/netbox/templates/ipam/inc/panels/fhrp_groups.html b/netbox/templates/ipam/inc/panels/fhrp_groups.html index 98ad87697..d5e0102f9 100644 --- a/netbox/templates/ipam/inc/panels/fhrp_groups.html +++ b/netbox/templates/ipam/inc/panels/fhrp_groups.html @@ -40,12 +40,12 @@ {{ assignment.priority }} {% if perms.ipam.change_fhrpgroupassignment %} - + {% endif %} {% if perms.ipam.delete_fhrpgroupassignment %} - + {% endif %}