From df82f782be445f28cdbf2d2569bb1e00013467d5 Mon Sep 17 00:00:00 2001 From: Arthur Date: Thu, 7 Dec 2023 14:26:55 -0800 Subject: [PATCH] 14467 fix test --- netbox/extras/tests/test_views.py | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/netbox/extras/tests/test_views.py b/netbox/extras/tests/test_views.py index 944ae865c..f7bde889e 100644 --- a/netbox/extras/tests/test_views.py +++ b/netbox/extras/tests/test_views.py @@ -120,6 +120,31 @@ class CustomFieldChoiceSetTestCase(ViewTestCases.PrimaryObjectViewTestCase): 'description': 'New description', } + # These are here as extra_choices field splits on colon, but is returned + # from DB as comma separated. So we exclude them in validation_excluded_fields + # but test they are actually set correctly here. + def _check_extra_choices_data(self): + instance = self._get_queryset().last() + form_data = self.form_data + form_data['extra_choices'] = form_data['extra_choices'].replace(':', ',') + self.assertInstanceEqual(instance, form_data) + + def test_create_object_with_constrained_permission(self): + super().test_create_object_with_constrained_permission() + self._check_extra_choices_data() + + def test_create_object_with_permission(self): + super().test_create_object_with_permission() + self._check_extra_choices_data() + + def test_edit_object_with_constrained_permission(self): + super().test_edit_object_with_constrained_permission() + self._check_extra_choices_data() + + def test_edit_object_with_permission(self): + super().test_edit_object_with_permission() + self._check_extra_choices_data() + class CustomLinkTestCase(ViewTestCases.PrimaryObjectViewTestCase): model = CustomLink