NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-13 16:47:34 -06:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

fix(ipam): Correct usage of the queryset.none method (#19678)

Browse Source 
Ensures the `queryset.none()` method is called properly with
parentheses. This fixes a potential issue where the method would not
execute as intended, improving the stability and correctness of the
filter logic.
This commit is contained in:
Martin Hauser 2025-06-09 14:45:40 +02:00 committed by GitHub
parent 2680f855ff
commit dda0a55e5e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
netbox/ipam/filtersets.py
View File

@ -449,7 +449,7 @@ class PrefixFilterSet(NetBoxModelFilterSet, ScopedFilterSet, TenancyFilterSet, C
@extend_schema_field(OpenApiTypes.STR) @extend_schema_field(OpenApiTypes.STR)
def filter_present_in_vrf(self, queryset, name, vrf): def filter_present_in_vrf(self, queryset, name, vrf):
if vrf is None: if vrf is None:
return queryset.none return queryset.none()
return queryset.filter( return queryset.filter(
Q(vrf=vrf) | Q(vrf=vrf) |
Q(vrf__export_targets__in=vrf.import_targets.all()) Q(vrf__export_targets__in=vrf.import_targets.all())
@ -729,7 +729,7 @@ class IPAddressFilterSet(NetBoxModelFilterSet, TenancyFilterSet, ContactModelFil
@extend_schema_field(OpenApiTypes.STR) @extend_schema_field(OpenApiTypes.STR)
def filter_present_in_vrf(self, queryset, name, vrf): def filter_present_in_vrf(self, queryset, name, vrf):
if vrf is None: if vrf is None:
return queryset.none return queryset.none()
return queryset.filter( return queryset.filter(
Q(vrf=vrf) | Q(vrf=vrf) |
Q(vrf__export_targets__in=vrf.import_targets.all()) Q(vrf__export_targets__in=vrf.import_targets.all())