From dd2ca387a5e1f409db38e4ba23d40a4c4b876be3 Mon Sep 17 00:00:00 2001
From: Brian Tiemann <btman@mac.com>
Date: Wed, 29 Jan 2025 18:22:22 -0500
Subject: [PATCH] Skip incompatible plugins during startup and remove from
 PLUGINS

---
 netbox/core/exceptions.py         |  7 +++++++
 netbox/netbox/plugins/__init__.py |  5 +++--
 netbox/netbox/settings.py         | 10 +++++-----
 3 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/netbox/core/exceptions.py b/netbox/core/exceptions.py
index 8412b0378..5790704c2 100644
--- a/netbox/core/exceptions.py
+++ b/netbox/core/exceptions.py
@@ -1,2 +1,9 @@
+from django.core.exceptions import ImproperlyConfigured
+
+
 class SyncError(Exception):
     pass
+
+
+class IncompatiblePluginError(ImproperlyConfigured):
+    pass
diff --git a/netbox/netbox/plugins/__init__.py b/netbox/netbox/plugins/__init__.py
index bb3280ac4..b7bb0ef9f 100644
--- a/netbox/netbox/plugins/__init__.py
+++ b/netbox/netbox/plugins/__init__.py
@@ -6,6 +6,7 @@ from django.core.exceptions import ImproperlyConfigured
 from django.utils.module_loading import import_string
 from packaging import version
 
+from core.exceptions import IncompatiblePluginError
 from netbox.registry import registry
 from netbox.search import register_search
 from netbox.utils import register_data_backend
@@ -140,14 +141,14 @@ class PluginConfig(AppConfig):
         if cls.min_version is not None:
             min_version = version.parse(cls.min_version)
             if current_version < min_version:
-                raise ImproperlyConfigured(
+                raise IncompatiblePluginError(
                     f"Plugin {cls.__module__} requires NetBox minimum version {cls.min_version} (current: "
                     f"{netbox_version})."
                 )
         if cls.max_version is not None:
             max_version = version.parse(cls.max_version)
             if current_version > max_version:
-                raise ImproperlyConfigured(
+                raise IncompatiblePluginError(
                     f"Plugin {cls.__module__} requires NetBox maximum version {cls.max_version} (current: "
                     f"{netbox_version})."
                 )
diff --git a/netbox/netbox/settings.py b/netbox/netbox/settings.py
index a17bb7730..ad722e3a9 100644
--- a/netbox/netbox/settings.py
+++ b/netbox/netbox/settings.py
@@ -11,6 +11,7 @@ from django.core.exceptions import ImproperlyConfigured, ValidationError
 from django.core.validators import URLValidator
 from django.utils.translation import gettext_lazy as _
 
+from core.exceptions import IncompatiblePluginError
 from netbox.config import PARAMS as CONFIG_PARAMS
 from netbox.constants import RQ_QUEUE_DEFAULT, RQ_QUEUE_HIGH, RQ_QUEUE_LOW
 from netbox.plugins import PluginConfig
@@ -790,6 +791,7 @@ if 'extras.events.process_event_queue' not in EVENTS_PIPELINE:
     EVENTS_PIPELINE.insert(0, 'extras.events.process_event_queue')
 
 # Register any configured plugins
+incompatible_plugins = []
 for plugin_name in PLUGINS:
     try:
         # Import the plugin module
@@ -843,11 +845,6 @@ for plugin_name in PLUGINS:
     sorted_apps = reversed(list(dict.fromkeys(reversed(INSTALLED_APPS))))
     INSTALLED_APPS = list(sorted_apps)
 
-    # Validate user-provided configuration settings and assign defaults
-    if plugin_name not in PLUGINS_CONFIG:
-        PLUGINS_CONFIG[plugin_name] = {}
-    plugin_config.validate(PLUGINS_CONFIG[plugin_name], RELEASE.version)
-
     # Add middleware
     plugin_middleware = plugin_config.middleware
     if plugin_middleware and type(plugin_middleware) in (list, tuple):
@@ -869,6 +866,9 @@ for plugin_name in PLUGINS:
         else:
             raise ImproperlyConfigured(f"events_pipline in plugin: {plugin_name} must be a list or tuple")
 
+[PLUGINS.remove(x) for x in incompatible_plugins]
+
+
 # UNSUPPORTED FUNCTIONALITY: Import any local overrides.
 try:
     from .local_settings import *