From db2993035d03552a78ca99f1f243fbec9d08493a Mon Sep 17 00:00:00 2001 From: thatmattlove Date: Mon, 30 Aug 2021 17:48:33 -0700 Subject: [PATCH] Fixes #7075: Wrap label selectors in quotes to ensure IDs with spaces are properly selected --- netbox/project-static/dist/netbox.js | Bin 321407 -> 321411 bytes netbox/project-static/dist/netbox.js.map | Bin 309956 -> 309956 bytes .../src/select/api/apiSelect.ts | 2 +- netbox/project-static/src/select/static.ts | 2 +- 4 files changed, 2 insertions(+), 2 deletions(-) diff --git a/netbox/project-static/dist/netbox.js b/netbox/project-static/dist/netbox.js index a6c9697730e5186459877055b1d2a4998b700558..76e025f4cd1018c6ee910eb86befe237485d5b88 100644 GIT binary patch delta 57 zcmex=PPqBJa6=1Y3sVd87M7`#1(j5)OENNx^^y{cQ}r@aYL&JxnatA7%Lx*P@XZ#o Hc)9@qdu9}< delta 53 zcmZoZFZ}FEi5Z*gp(Z|lXbiu9laq$prfn#_B}N$Yq|KqGOmt}{yIRx LlI`W~EWXA7@mv*^ delta 64 zcmX@|Rp`i9p@tU57N!>FEi5Z*gcBVd6Lq{D9larhzoV<^_B}N$Yq|KqGOmt}{yIRx LqV47FEWXA7@5mK} diff --git a/netbox/project-static/src/select/api/apiSelect.ts b/netbox/project-static/src/select/api/apiSelect.ts index 51648fc48..a7c9ca783 100644 --- a/netbox/project-static/src/select/api/apiSelect.ts +++ b/netbox/project-static/src/select/api/apiSelect.ts @@ -715,7 +715,7 @@ export class APISelect { private getPlaceholder(): string { let placeholder = this.name; if (this.base.id) { - const label = document.querySelector(`label[for=${this.base.id}]`) as HTMLLabelElement; + const label = document.querySelector(`label[for="${this.base.id}"]`) as HTMLLabelElement; // Set the placeholder text to the label value, if it exists. if (label !== null) { placeholder = `Select ${label.innerText.trim()}`; diff --git a/netbox/project-static/src/select/static.ts b/netbox/project-static/src/select/static.ts index 550e5ba7d..c649537ba 100644 --- a/netbox/project-static/src/select/static.ts +++ b/netbox/project-static/src/select/static.ts @@ -4,7 +4,7 @@ import { getElements } from '../util'; export function initStaticSelect(): void { for (const select of getElements('.netbox-static-select')) { if (select !== null) { - const label = document.querySelector(`label[for=${select.id}]`) as HTMLLabelElement; + const label = document.querySelector(`label[for="${select.id}"]`) as HTMLLabelElement; let placeholder; if (label !== null) {