NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 23:32:17 -06:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Fixes #16964: Ensure configured password validators are enforced (#16990)

Browse Source 
* Closes #16964: Validate password when creating a new user or updating password for an existing user

* Add serializer validation & tests

---------

Co-authored-by: Nishant Gaglani <nishantgaglani@gmail.com>
This commit is contained in:
Jeremy Stretch
2024-07-26 07:58:14 -04:00
committed by GitHub
parent cc72a58c1e
commit d8c7282fdb
4 changed files with 71 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
netbox/users/forms/model_forms.py
View File

@@ -1,6 +1,6 @@
from django import forms
from django.conf import settings
from django.contrib.auth import get_user_model
from django.contrib.auth import get_user_model, password_validation
from django.contrib.postgres.forms import SimpleArrayField
from django.core.exceptions import FieldError
from django.utils.safestring import mark_safe
@@ -227,6 +227,10 @@ class UserForm(forms.ModelForm):
if self.cleaned_data['password'] and self.cleaned_data['password'] != self.cleaned_data['confirm_password']:
raise forms.ValidationError(_("Passwords do not match! Please check your input and try again."))
# Enforce password validation rules (if configured)
if self.cleaned_data['password']:
password_validation.validate_password(self.cleaned_data['password'], self.instance)
class GroupForm(forms.ModelForm):
users = DynamicModelMultipleChoiceField(