From d5f2bab132d62f59bab4eb6028b7a11a17edfc8b Mon Sep 17 00:00:00 2001 From: Arthur Hanson Date: Mon, 30 Sep 2024 13:20:01 -0700 Subject: [PATCH] 16547 fix test cases --- netbox/dcim/tests/test_filtersets.py | 2 +- netbox/dcim/tests/test_views.py | 2 +- netbox/netbox/models/mixins.py | 2 +- netbox/wireless/tests/test_filtersets.py | 9 +++++---- netbox/wireless/tests/test_views.py | 5 +++-- 5 files changed, 11 insertions(+), 9 deletions(-) diff --git a/netbox/dcim/tests/test_filtersets.py b/netbox/dcim/tests/test_filtersets.py index afb360d76..f0b1454fb 100644 --- a/netbox/dcim/tests/test_filtersets.py +++ b/netbox/dcim/tests/test_filtersets.py @@ -5,7 +5,7 @@ from dcim.choices import * from dcim.filtersets import * from dcim.models import * from ipam.models import ASN, IPAddress, RIR, VRF -from netbox.choices import ColorChoices +from netbox.choices import ColorChoices, WeightUnitChoices from tenancy.models import Tenant, TenantGroup from users.models import User from utilities.testing import ChangeLoggedFilterSetTests, create_test_device diff --git a/netbox/dcim/tests/test_views.py b/netbox/dcim/tests/test_views.py index 7d6c34337..18a8da445 100644 --- a/netbox/dcim/tests/test_views.py +++ b/netbox/dcim/tests/test_views.py @@ -10,7 +10,7 @@ from dcim.choices import * from dcim.constants import * from dcim.models import * from ipam.models import ASN, RIR, VLAN, VRF -from netbox.choices import CSVDelimiterChoices, ImportFormatChoices +from netbox.choices import CSVDelimiterChoices, ImportFormatChoices, WeightUnitChoices from tenancy.models import Tenant from users.models import User from utilities.testing import ViewTestCases, create_tags, create_test_device, post_data diff --git a/netbox/netbox/models/mixins.py b/netbox/netbox/models/mixins.py index dd28126b7..804e0b71a 100644 --- a/netbox/netbox/models/mixins.py +++ b/netbox/netbox/models/mixins.py @@ -2,7 +2,7 @@ from django.core.exceptions import ValidationError from django.db import models from django.utils.translation import gettext_lazy as _ from netbox.choices import * -from utilities.conversion import to_grams +from utilities.conversion import to_grams, to_meters __all__ = ( 'DistanceMixin', diff --git a/netbox/wireless/tests/test_filtersets.py b/netbox/wireless/tests/test_filtersets.py index 46eec4d7b..5c932928c 100644 --- a/netbox/wireless/tests/test_filtersets.py +++ b/netbox/wireless/tests/test_filtersets.py @@ -3,6 +3,7 @@ from django.test import TestCase from dcim.choices import InterfaceTypeChoices, LinkStatusChoices from dcim.models import Interface from ipam.models import VLAN +from netbox.choices import DistanceUnitChoices from tenancy.models import Tenant from wireless.choices import * from wireless.filtersets import * @@ -261,7 +262,7 @@ class WirelessLinkTestCase(TestCase, ChangeLoggedFilterSetTests): auth_psk='PSK1', tenant=tenants[0], distance=10, - distance_unit=WirelessLinkDistanceUnitChoices.UNIT_FOOT, + distance_unit=DistanceUnitChoices.UNIT_FOOT, description='foobar1' ).save() WirelessLink( @@ -274,7 +275,7 @@ class WirelessLinkTestCase(TestCase, ChangeLoggedFilterSetTests): auth_psk='PSK2', tenant=tenants[1], distance=20, - distance_unit=WirelessLinkDistanceUnitChoices.UNIT_METER, + distance_unit=DistanceUnitChoices.UNIT_METER, description='foobar2' ).save() WirelessLink( @@ -286,7 +287,7 @@ class WirelessLinkTestCase(TestCase, ChangeLoggedFilterSetTests): auth_cipher=WirelessAuthCipherChoices.CIPHER_AES, auth_psk='PSK3', distance=30, - distance_unit=WirelessLinkDistanceUnitChoices.UNIT_METER, + distance_unit=DistanceUnitChoices.UNIT_METER, tenant=tenants[2], ).save() WirelessLink( @@ -324,7 +325,7 @@ class WirelessLinkTestCase(TestCase, ChangeLoggedFilterSetTests): self.assertEqual(self.filterset(params, self.queryset).qs.count(), 2) def test_distance_unit(self): - params = {'distance_unit': WirelessLinkDistanceUnitChoices.UNIT_FOOT} + params = {'distance_unit': DistanceUnitChoices.UNIT_FOOT} self.assertEqual(self.filterset(params, self.queryset).qs.count(), 1) def test_description(self): diff --git a/netbox/wireless/tests/test_views.py b/netbox/wireless/tests/test_views.py index 055edf73c..e8fd4340d 100644 --- a/netbox/wireless/tests/test_views.py +++ b/netbox/wireless/tests/test_views.py @@ -2,6 +2,7 @@ from wireless.choices import * from wireless.models import * from dcim.choices import InterfaceTypeChoices, LinkStatusChoices from dcim.models import Interface +from netbox.choices import DistanceUnitChoices from tenancy.models import Tenant from utilities.testing import ViewTestCases, create_tags, create_test_device @@ -161,7 +162,7 @@ class WirelessLinkTestCase(ViewTestCases.PrimaryObjectViewTestCase): 'interface_b': interfaces[7].pk, 'status': LinkStatusChoices.STATUS_PLANNED, 'distance': 100, - 'distance_unit': WirelessLinkDistanceUnitChoices.UNIT_FOOT, + 'distance_unit': DistanceUnitChoices.UNIT_FOOT, 'tenant': tenants[1].pk, 'tags': [t.pk for t in tags], } @@ -183,5 +184,5 @@ class WirelessLinkTestCase(ViewTestCases.PrimaryObjectViewTestCase): cls.bulk_edit_data = { 'status': LinkStatusChoices.STATUS_PLANNED, 'distance': 50, - 'distance_unit': WirelessLinkDistanceUnitChoices.UNIT_METER, + 'distance_unit': DistanceUnitChoices.UNIT_METER, }