From d414304168278f33959fff37f19ff25e0b4062f9 Mon Sep 17 00:00:00 2001 From: Arthur Date: Tue, 19 Sep 2023 12:51:57 -0700 Subject: [PATCH] 13809 fix ConfigRevision edit, check if custom validator JSON serializable --- netbox/extras/forms/model_forms.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/netbox/extras/forms/model_forms.py b/netbox/extras/forms/model_forms.py index c8afeb090..a1ecb61ad 100644 --- a/netbox/extras/forms/model_forms.py +++ b/netbox/extras/forms/model_forms.py @@ -531,6 +531,15 @@ class ConfigRevisionForm(BootstrapMixin, forms.ModelForm, metaclass=ConfigFormMe if type(value) in (tuple, list): value = ', '.join(value) self.fields[param.name].initial = value + + if param.name == 'CUSTOM_VALIDATORS': + # custom validators can be either dict or functions + try: + json.dumps(value) + except TypeError: + self.fields[param.name].initial = None + self.fields[param.name].disabled = True + if is_static: self.fields[param.name].disabled = True