NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-08-08 08:38:16 -06:00
Code Issues Actions 15 Packages Projects Releases Wiki Activity

Misc cleanup

Browse Source
This commit is contained in:
Jeremy Stretch 2024-07-18 16:44:26 -04:00
parent 00dc9c464b
commit d3668ce328
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
netbox/extras/models/models.py
View File

@ -125,12 +125,6 @@ class EventRule(CustomFieldsMixin, ExportTemplatesMixin, TagsMixin, ChangeLogged
def clean(self): def clean(self):
super().clean() super().clean()
# At least one action type must be selected
if not self.event_types:
raise ValidationError(
_("At least one event type must be selected: create, update, delete, job start, and/or job end.")
)
# Validate that any conditions are in the correct format # Validate that any conditions are in the correct format
if self.conditions: if self.conditions:
try: try:

2
netbox/extras/tests/test_conditions.py
View File

@ -298,7 +298,7 @@ class ConditionSetTest(TestCase):
webhook = Webhook.objects.create(name='Webhook 100', payload_url='http://example.com/?1', http_method='POST') webhook = Webhook.objects.create(name='Webhook 100', payload_url='http://example.com/?1', http_method='POST')
form = EventRuleForm({ form = EventRuleForm({
"name": "Event Rule 1", "name": "Event Rule 1",
'event_types': [OBJECT_CREATED, OBJECT_UPDATED], "event_types": [OBJECT_CREATED, OBJECT_UPDATED],
"action_object_type": ct.pk, "action_object_type": ct.pk,
"action_type": "webhook", "action_type": "webhook",
"action_choice": webhook.pk, "action_choice": webhook.pk,