From 8f9dcf5a97d007f6341d5f0a5c09d68386c68f07 Mon Sep 17 00:00:00 2001 From: Sander Steffann Date: Thu, 4 Jun 2020 17:46:09 +0200 Subject: [PATCH] Avoid unnecessary queries in Cable.from_db --- netbox/dcim/models/__init__.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/netbox/dcim/models/__init__.py b/netbox/dcim/models/__init__.py index 1f6478119..98cd37c1c 100644 --- a/netbox/dcim/models/__init__.py +++ b/netbox/dcim/models/__init__.py @@ -2115,9 +2115,9 @@ class Cable(ChangeLoggedModel): """ instance = super().from_db(db, field_names, values) - instance._orig_termination_a_type = instance.termination_a_type + instance._orig_termination_a_type_id = instance.termination_a_type_id instance._orig_termination_a_id = instance.termination_a_id - instance._orig_termination_b_type = instance.termination_b_type + instance._orig_termination_b_type_id = instance.termination_b_type_id instance._orig_termination_b_id = instance.termination_b_id return instance @@ -2154,14 +2154,14 @@ class Cable(ChangeLoggedModel): if self.pk: err_msg = 'Cable termination points may not be modified. Delete and recreate the cable instead.' if ( - self.termination_a_type != self._orig_termination_a_type or + self.termination_a_type_id != self._orig_termination_a_type_id or self.termination_a_id != self._orig_termination_a_id ): raise ValidationError({ 'termination_a': err_msg }) if ( - self.termination_b_type != self._orig_termination_b_type or + self.termination_b_type_id != self._orig_termination_b_type_id or self.termination_b_id != self._orig_termination_b_id ): raise ValidationError({