From d2c32c959402e4ca66c0555b3c1c085fd6ee98c8 Mon Sep 17 00:00:00 2001
From: Daniel Sheppard <dans@dansheps.com>
Date: Tue, 5 Sep 2023 13:40:33 -0500
Subject: [PATCH] Add tests

---
 netbox/extras/tests/test_customfields.py | 116 +++++++++++++++++++++++
 1 file changed, 116 insertions(+)

diff --git a/netbox/extras/tests/test_customfields.py b/netbox/extras/tests/test_customfields.py
index 019aef235..aaf8e44ca 100644
--- a/netbox/extras/tests/test_customfields.py
+++ b/netbox/extras/tests/test_customfields.py
@@ -427,6 +427,122 @@ class CustomFieldTest(TestCase):
         self.assertNotIn('field1', site.custom_field_data)
         self.assertEqual(site.custom_field_data['field2'], FIELD_DATA)
 
+    def test_default_value_validation(self):
+        choiceset = CustomFieldChoiceSet.objects.create(name="Test Choice Set", extra_choices=(('choice1', 'Choice 1'), ('choice2', 'Choice 2')))
+        site = Site.objects.create(
+            name='Site 1',
+            slug='site-1'
+        )
+        object_type = ContentType.objects.get_for_model(Site)
+
+        cfs = (
+            # Test Text
+            (
+                # Should Pass
+                CustomField(name='test', type='text', required=True, default="Test Text"),
+            ),
+            # Test Integer
+            (
+                # Should Pass
+                CustomField(name='test', type='integer', required=True, default=1),
+                # Should Fail
+                CustomField(name='test', type='integer', required=True, default="Not a  Integer"),
+            ),
+
+            # Test Boolean
+            (
+                # Should Pass
+                CustomField(name='test', type='boolean', required=True, default=True),
+                # Should Fail
+                CustomField(name='test', type='boolean', required=True, default="Not a  Boolean"),
+            ),
+            # Test Date
+            (
+                # Should Pass
+                CustomField(name='test', type='date', required=True, default="2023-02-25"),
+                # Should Fail
+                CustomField(name='test', type='date', required=True, default="Not a  Date"),
+            ),
+            # Test Date + Time
+            (
+                # Should Pass
+                CustomField(name='test', type='datetime', required=True, default="2023-02-25 02:02:02"),
+                # Should Fail
+                CustomField(name='test', type='datetime', required=True, default="Not a DateTime"),
+            ),
+            # Test URL
+            (
+                # Should Pass
+                CustomField(name='test', type='url', required=True, default="https://www.netbox.dev"),
+            ),
+            # Test JSON
+            (
+                # Should Pass
+                CustomField(name='test', type='json', required=True, default='{"test": "object"}'),
+            ),
+            # Test Selection
+            (
+                # Should Pass
+                CustomField(name='test', type='select', required=True, choice_set=choiceset, default='choice1'),
+                # Should Fail
+                CustomField(
+                    name='test',
+                    type='select',
+                    required=True,
+                    choice_set=choiceset,
+                    default="Not a Selection option"
+                ),
+            ),
+            # Test Multiple Selection
+            (
+                # Should Pass
+                CustomField(
+                    name='test',
+                    type='multiselect',
+                    required=True,
+                    choice_set=choiceset,
+                    default=['choice1', ]
+                ),
+                # Should Fail
+                CustomField(
+                    name='test',
+                    type='multiselect',
+                    required=True,
+                    choice_set=choiceset,
+                    default="Not a Selection option"
+                ),
+            ),
+            # Test Object
+            (
+                # Should Pass
+                CustomField(name='test', type='object', required=True, object_type=object_type, default=1),
+                # Should Fail
+                CustomField(name='test', type='object', required=True, object_type=object_type, default="Site 1"),
+            ),
+            # Test Multiple Object
+            (
+                # Should Pass
+                CustomField(
+                    name='test',
+                    type='multiobject',
+                    required=True,
+                    object_type=object_type,
+                    default=[site.pk, ]
+                ),
+                # Should Fail
+                CustomField(name='test', type='multiobject', required=True, object_type=object_type, default="Site 1"),
+            ),
+        )
+
+        for cftest in cfs:
+            # Check for valid default data
+            self.assertIsNone(cftest[0].full_clean())
+
+            # Check for invalid data
+            if len(cftest) > 1:
+                with self.assertRaises(ValidationError):
+                    cftest[1].full_clean()
+
 
 class CustomFieldManagerTest(TestCase):