From d164833c6ea1f36e156bf0921790247e23cdb7ad Mon Sep 17 00:00:00 2001
From: Jeremy Stretch <jstretch@netboxlabs.com>
Date: Wed, 7 Feb 2024 15:25:44 -0500
Subject: [PATCH] Misc cleanup

---
 netbox/project-static/dist/netbox.js          | Bin 374400 -> 374389 bytes
 netbox/project-static/dist/netbox.js.map      | Bin 339676 -> 339689 bytes
 .../src/select/classes/dynamicTomSelect.ts    |   2 +-
 netbox/project-static/src/select/dynamic.ts   |  28 +++++++++++++-----
 4 files changed, 22 insertions(+), 8 deletions(-)

diff --git a/netbox/project-static/dist/netbox.js b/netbox/project-static/dist/netbox.js
index 60f8977d3aba7532ba78506c40b687a126fca68c..d8a0e00098c899bf4aa8855789ac8cad325b4ff6 100644
GIT binary patch
delta 1178
zcmYjPYfPJE6wY}$FJa6s!(zqAMgxd#R|}g<HN}Q-nT)Mt7Z}J~{8mdpD3lg@0X~$`
zp>eQLOuCI@qQe=tajjf5yqcI86Jw&rsGDFGqFF+W#(-`y?uR%0ipKTVlRW1+&wI{!
z-pHEnw^d!_9cUN^KOGx}7&yh+FmME~_%#NZ04|Ys9%3bMm|ndOe^SpPJVGCR4GSYn
zkWC|t(4uiG#d6r^3VHlKeMo4QKm!mG4}JrahrvT18`uGjCrRQXy^%ex@g-3KavRxC
znm`g2q~j)5PPa|WLZ6#hzQ&(abkg4@_KG?x?O-3KZ}KYkdf8w!yU1x}20H6tR`G$A
z1=7?dc9p1aL6}+{OiwptwofcN*zyC=NOLkXs4(PURU)s6Ev0A3ioG)7)2!I{C$L?l
z2UuYWG?OjNz6Y7~ohr0bY8PA2XjANUK~+@iwTJyGHVIuf%SnSavPM`9G|`y|3qYs%
zE5e=t=p<V|^XnzW-r!Qjiem3_s#yA8vl6iT++BJ}eA3T~H-U1R4>7@qQVOnZX{fL}
zf`(@s4MwB6vVu;XLalH-gRUJ}p=M9e5_E?`9$!<?(&p?w*q+EBDCP&zmZmjVNcNpY
zMR&6)mni#1o<&<@I8Vzl%-(Xh$5tVk>DEciqB}8kSlR<_uix2d%a#4Ea4^>#aQhnF
z0o!x_jTda?Qm;AK><@bz9SPOB6V^<6?;IL=sbuhY=)@G}h}83VAO%WAE#WGMgH(DE
zzf(a!idOo46pQGkQ4E1Y{4t76K<k$<jlOstb7=4qc7kK!4Gb`-rr?{{$66&i_B`rE
z=4Jd0pp|Z3!8*0}*j0=`6}@{EKZQdHe=UuS;mayjFpd{=ha`jBV-Cy4USse7|MQ6W
zY8-FEy+;y*Ch>bEDtHaIQ{NP((hrkZ4=ti(3O57f)Bb66q_#+ETzl!_G|DQ4aqNL7
zsV|O2P)4(H+yzI)N*rt8p0W*R^U;k<EYDyeb<AKGI;eUE^C*25SJcLzXK|GENR$!f
z_t7>|cb}TWLa3wVIV{q4NXBB>A24{`A-%_=_sdWBi0$*pAI_+k?2jf#+8}n{z<w>%
z3$co87ob60>E|X6mGtFlUQO2q_%<pY-~>-m&H&G*Uk3OJ>=V}q`3osTQGP$QMY)NV
zqg+SvD7UCO^|+aIE6R7Px`&4O`&nci<7JdL#<gsZLObWxGatW<TSvzEW|GHvK6Ht*
zV>|-XGNCfM30@0(sC9x*tA(sd{w;%Ux--phL$~-b&UFAaV*M??kidmmeiB&izpkQc
Op63G83h&!IGvyy$_n!9v

delta 1201
zcmZ8gdu-EH6wbLj7xr+P(J==bu8c+7u1E!Ku%qH0!X5?YCXAubls>jX*WdW9UDr*p
zOcFNS7Sat*qPQW*UUZI4!~MrZml#Bii3*!fh{@DM-4cx94-;kHE=Csr`f|Q|?sv}l
z&b@c$G9vRCk$0iC2bySK4@5x`^F6>39O92CqyzXwVjo1eLOH#D9sXkFb~=3>GO2GG
zH1y#OxI%OT*3-~5)Kcp-WK;GG+y%GD`U*y$g#caEu^p*_aDgZ2cLuzQU+X2Uo^4L`
zE}{J7*0Wzz{Yxm7UNErYRCNi}M0X8rEq!KSc{E^Pk5W!P3(0mVpG_qvIl|T&k4|s&
zk;BY%;G-@ZdqTW#W@@4wW#d*^5}b6{#<bLFW@dVzj-`uf8~bh*1Zl#<bo7dim5X(C
zY$iF)6}E1Vi+RG<ia6GbWR-1501sJ$>?d%Mwpl_wEeo-Qw8pS?Pm@e~&SwoO5*tKD
z3(HA_MlwfOH8jwv2vea>{2gIi0P4un&J=BP*jnq9$@Z`{<d9hS@8z&+^}9pbX7O=5
zD@X$SN#4Z-?@D<1%lm6ethOfIL6=UiH`bQW@#Clwwgc$QPk78^5+8M<CGoy{Hka5b
z?F7#xV-zRp_A$%^Bi)K(Hm&W&irzIdtM<E8rO~B?{FM&X?GIRT4=S#3uF<LZ1FGUH
z^EU=1x5XRBr*e&rs@tbHT$Wsq;tV$B8XFufyBg#BY_iDeMycR(tClupk+aC+W4&nL
z#de+7OGn@4Iix+s`ISB_O@LxiMmWczkj!u3t>uMwU6s@5riB=;BvU_T!7jSpj~l41
z9|Kg;k0y~bfSW<md(Yun*dgwmLzRJz>M!6+Y^R;}y@*<o^cH>!u#>*%=IQjyMJ$pD
z#zBn0VHz96PoRuihVZ<MvWD@Dj3$OL9V*4uVf+DBRL1+%AN}u*R@o`*EIvdtqqrYR
z#p9PS1>g`p9Yfo)QoCGN6-8s{k<_0tY=t}ujG+m((Zw;`2u0%SF|3BnZHuDDqW@{{
zrtimb9eKtvNJZnAM+@UPD<x(xV?R4$r>Ozy!v`^3P6HECbT@r2L9@rMFYqX;&gTwj
zy<V;2dH#sdOd@|It<`SbWHQ}be2vh5gY6n<6|p&-KLa)5wRUdctaed4oxVNEpM>pn
zt%GNise=<~I`|s;v4hXTUU99Hznma{vUG7JIl6g1Rdn+Q=|VSOPhH(SgMRMjn`GYV
z9{ye?gvmI>3n_DmYiMSW7g56yUjfgE$PkZ!JcSW{;MEbHLWf59dC8}a@|z4o^jnPo
v4k2-KjAuYfOE~U*TYNB@dK0t7>T!M=phaA|%#Q(73&SKg$I<Z)Pfz#<uM?#m

diff --git a/netbox/project-static/dist/netbox.js.map b/netbox/project-static/dist/netbox.js.map
index d6ff2317c228d6abd761fadd3c488994f0aae0bc..702a0af12e36e286fe698d4cc657d0761de97276 100644
GIT binary patch
delta 205
zcmca}SLEegk%kt=7N!>FEi4&kypG;F!H$l>I+2d9RZiQp%vesaaXP2yxH~!~>v&E#
zv}KWCbf4~J%Mu8r<^ZYbpLkhC>cbr!BY|q%qjUm6nw=dTopsWk9Noi!<~Sw-WjvE~
zk{umWLFV}DB!a|Bog5u2opk&i-A!E}x&j^DLx6n8K%jnSKM2dy(KAd3Y<j4pW4;r}
bWLF(ukRiU#rp^`4AhXPzws+XEgnR%1n*KX@

delta 218
zcmaEPSLDuJk%kt=7N!>FEi4&kOs)~zOU+nLut|6pIO#+>Iu<+WxH~$AgNSS=9cM?^
z>G8HKfsC%xHv%dCKu5=5prE6(PP&t$bJ%o7I~LJ;psqxqdgmmaWJkwTkWPP{M37ji
zlcQs$la9Zmv#E<tF_2RVGTgb$Nhj6OF&!+C;RI5etP|?!oT39ZJ<!oPL?_(QF;d6V
m(K!mJ*)b4kqq84`<?C$j6avy>26CKpj<b&U_PKT}J|6(tIzLkY

diff --git a/netbox/project-static/src/select/classes/dynamicTomSelect.ts b/netbox/project-static/src/select/classes/dynamicTomSelect.ts
index f616adbe8..13b483dfe 100644
--- a/netbox/project-static/src/select/classes/dynamicTomSelect.ts
+++ b/netbox/project-static/src/select/classes/dynamicTomSelect.ts
@@ -121,7 +121,7 @@ export class DynamicTomSelect extends TomSelect {
 
     // Add standard parameters
     query['brief'] = [true];
-    query['limit'] = [100];
+    query['limit'] = [this.settings.maxOptions];
 
     return queryString.stringifyUrl({ url, query });
   }
diff --git a/netbox/project-static/src/select/dynamic.ts b/netbox/project-static/src/select/dynamic.ts
index f7a272f71..360077c11 100644
--- a/netbox/project-static/src/select/dynamic.ts
+++ b/netbox/project-static/src/select/dynamic.ts
@@ -3,14 +3,17 @@ import { DynamicTomSelect } from './classes/dynamicTomSelect'
 
 const VALUE_FIELD = 'id';
 const LABEL_FIELD = 'display';
+const MAX_OPTIONS = 100;
 
 
 // Render the HTML for a dropdown option
 function renderOption(data: any, escape: Function) {
-  // If the object has a `_depth` property, indent its display text
+
+  // If the option has a `_depth` property, indent its label
   if (typeof data._depth === 'number' && data._depth > 0) {
     return `<div>${'─'.repeat(data._depth)} ${escape(data[LABEL_FIELD])}</div>`;
   }
+
   return `<div>${escape(data[LABEL_FIELD])}</div>`;
 }
 
@@ -20,19 +23,30 @@ export function initDynamicSelects(): void {
 
   for (const select of getElements<HTMLSelectElement>('select.api-select')) {
     new DynamicTomSelect(select, {
-      plugins: ['clear_button'],
       valueField: VALUE_FIELD,
       labelField: LABEL_FIELD,
+      maxOptions: MAX_OPTIONS,
+
+      // Provides the "clear" button on the widget
+      plugins: ['clear_button'],
+
+      // Disable local search (search is performed on the backend)
       searchField: [],
+
+      // Reference the disabled-indicator attr on the <select> element to determine
+      // the name of the attribute which indicates whether an option should be disabled
       disabledField: select.getAttribute('disabled-indicator') || undefined,
-      copyClassesToDropdown: false,
-      dropdownParent: 'body',
-      controlInput: '<input>',
+
+      // Load options from API immediately on focus
       preload: 'focus',
-      maxOptions: 100,
+
+      // Define custom rendering functions
       render: {
         option: renderOption
-      }
+      },
+
+      // By default, load() will be called only if query.length > 0
+      shouldLoad: function(): boolean { return true; }
 	});
   }