From cea1e3d090f35a28045d7994673f0990e9ec05e2 Mon Sep 17 00:00:00 2001 From: Jeremy Stretch Date: Fri, 31 Jan 2020 16:10:16 -0500 Subject: [PATCH] Fixes #4071: Enforce "view tag" permission on individual tag view --- docs/release-notes/version-2.7.md | 1 + netbox/extras/tests/test_views.py | 3 --- netbox/extras/views.py | 3 ++- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/docs/release-notes/version-2.7.md b/docs/release-notes/version-2.7.md index 0c0518dee..4cd35744a 100644 --- a/docs/release-notes/version-2.7.md +++ b/docs/release-notes/version-2.7.md @@ -12,6 +12,7 @@ * [#4049](https://github.com/netbox-community/netbox/issues/4049) - Restore missing `tags` field in IPAM service serializer * [#4052](https://github.com/netbox-community/netbox/issues/4052) - Fix error when bulk importing interfaces to virtual machines * [#4056](https://github.com/netbox-community/netbox/issues/4056) - Repair schema migration for Rack.outer_unit (from #3569) +* [#4071](https://github.com/netbox-community/netbox/issues/4071) - Enforce "view tag" permission on individual tag view --- diff --git a/netbox/extras/tests/test_views.py b/netbox/extras/tests/test_views.py index 0b9a0ffdf..0fc60dcd9 100644 --- a/netbox/extras/tests/test_views.py +++ b/netbox/extras/tests/test_views.py @@ -17,9 +17,6 @@ class TagTestCase(StandardTestCases.Views): test_create_object = None test_import_objects = None - # TODO: Restore test when #4071 is resolved - test_get_object = None - @classmethod def setUpTestData(cls): diff --git a/netbox/extras/views.py b/netbox/extras/views.py index 2fce98cc4..40f3466ef 100644 --- a/netbox/extras/views.py +++ b/netbox/extras/views.py @@ -37,7 +37,8 @@ class TagListView(PermissionRequiredMixin, ObjectListView): template_name = 'extras/tag_list.html' -class TagView(View): +class TagView(PermissionRequiredMixin, View): + permission_required = 'extras.view_tag' def get(self, request, slug):