NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-29 03:46:25 -06:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Revert "Add disable_htmx property on ObjectChildrenView to allow IP assignment flow to avoid htmx fragmentary rendering on object save"

Browse Source 
This reverts commit fa8f2ac377.
This commit is contained in:
Brian Tiemann 2024-12-17 11:13:49 -05:00
parent fa8f2ac377
commit ccfda54b50
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
netbox/dcim/views.py
View File

@ -1971,7 +1971,6 @@ class DeviceInterfacesView(DeviceComponentsView):
filterset = filtersets.InterfaceFilterSet filterset = filtersets.InterfaceFilterSet
filterset_form = forms.InterfaceFilterForm filterset_form = forms.InterfaceFilterForm
template_name = 'dcim/device/interfaces.html' template_name = 'dcim/device/interfaces.html'
disable_htmx = True
tab = ViewTab( tab = ViewTab(
label=_('Interfaces'), label=_('Interfaces'),
badge=lambda obj: obj.vc_interfaces().count(), badge=lambda obj: obj.vc_interfaces().count(),

4
netbox/netbox/views/generic/object_views.py
View File

@ -96,8 +96,6 @@ class ObjectChildrenView(ObjectView, ActionsMixin, TableMixin):
filterset = None filterset = None
filterset_form = None filterset_form = None
template_name = 'generic/object_children.html' template_name = 'generic/object_children.html'
# Currently used only to work around the singular behavior of the IP assignment flow in DeviceInterfacesView
disable_htmx = False
def get_children(self, request, parent): def get_children(self, request, parent):
""" """
@ -144,7 +142,7 @@ class ObjectChildrenView(ObjectView, ActionsMixin, TableMixin):
table = self.get_table(table_data, request, has_bulk_actions) table = self.get_table(table_data, request, has_bulk_actions)
# If this is an HTMX request, return only the rendered table HTML # If this is an HTMX request, return only the rendered table HTML
if htmx_partial(request) and not self.disable_htmx: if htmx_partial(request):
return render(request, 'htmx/table.html', { return render(request, 'htmx/table.html', {
'object': instance, 'object': instance,
'table': table, 'table': table,