From c818d63043f0ec1ab2ce360ac0666ea79f5e99b5 Mon Sep 17 00:00:00 2001 From: thatmattlove Date: Mon, 4 Oct 2021 09:19:18 -0700 Subject: [PATCH] Fixes #7427: Don't select hidden rows when selecting all in a table --- docs/release-notes/version-3.0.md | 1 + netbox/project-static/dist/netbox.js | Bin 322492 -> 322508 bytes netbox/project-static/dist/netbox.js.map | Bin 310799 -> 310799 bytes .../project-static/src/buttons/selectAll.ts | 2 +- 4 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/release-notes/version-3.0.md b/docs/release-notes/version-3.0.md index 7bba5c4db..cd33faea2 100644 --- a/docs/release-notes/version-3.0.md +++ b/docs/release-notes/version-3.0.md @@ -8,6 +8,7 @@ * [#6423](https://github.com/netbox-community/netbox/issues/6423) - Cache rendered REST API specifications * [#6708](https://github.com/netbox-community/netbox/issues/6708) - Add image attachment support for circuits, power panels * [#7387](https://github.com/netbox-community/netbox/issues/7387) - Enable arbitrary ordering of custom scripts +* [#7427](https://github.com/netbox-community/netbox/issues/7427) - Don't select hidden rows when selecting all in a table ### Bug Fixes diff --git a/netbox/project-static/dist/netbox.js b/netbox/project-static/dist/netbox.js index d4be77e327333507d80c1cb7ffe48fee86fc8dae..24524fad37ab67fb5c75fb4c80eb9ec14dc382a0 100644 GIT binary patch delta 40 wcmdmUUHHs(;f5B*7N!>FEi4Q62$U3A<>i-X=%wi9<>#epDr{e{hebvo08(cUMgRZ+ delta 23 fcmX?eU3kxR;f5B*7N!>FEi4Q6Y~QelMMfV0fldka diff --git a/netbox/project-static/dist/netbox.js.map b/netbox/project-static/dist/netbox.js.map index aadc192730cc44bd310fce4829ca501a9b533bfe..be7ed66c0701aa6c317101644c1248000206b25f 100644 GIT binary patch delta 25 hcmeDGBh>##sG)_ig{g&k3rq5RMwjg=^I2BQ0RW0|3DW=o delta 25 hcmeDGBh>##sG)_ig{g&k3rq5RM(6D*^I2BQ0RW0>3DN)n diff --git a/netbox/project-static/src/buttons/selectAll.ts b/netbox/project-static/src/buttons/selectAll.ts index 8b62ef0a0..64b98d390 100644 --- a/netbox/project-static/src/buttons/selectAll.ts +++ b/netbox/project-static/src/buttons/selectAll.ts @@ -36,7 +36,7 @@ function handleSelectAllToggle(event: Event): void { if (table !== null) { for (const element of table.querySelectorAll( - 'input[type="checkbox"][name="pk"]', + 'tr:not(.d-none) input[type="checkbox"][name="pk"]', )) { if (tableSelectAll.checked) { // Check all PK checkboxes if the select all checkbox is checked.