From c67355a6f911fd6d87a8f10b433f8f447914379c Mon Sep 17 00:00:00 2001 From: Arthur Date: Thu, 9 Oct 2025 08:21:59 -0700 Subject: [PATCH] 19615 log if duplicated params --- netbox/utilities/templatetags/builtins/tags.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/netbox/utilities/templatetags/builtins/tags.py b/netbox/utilities/templatetags/builtins/tags.py index f0cee4dea..400515166 100644 --- a/netbox/utilities/templatetags/builtins/tags.py +++ b/netbox/utilities/templatetags/builtins/tags.py @@ -1,3 +1,5 @@ +import logging + from django import template from django.templatetags.static import static from django.utils.safestring import mark_safe @@ -155,8 +157,14 @@ def static_with_params(path, **params): parsed = urlparse(static_url) existing_params = parse_qs(parsed.query) - # Add new parameters to existing ones + # Check for duplicate parameters and log warnings + logger = logging.getLogger(__name__) for key, value in params.items(): + if key in existing_params: + logger.warning( + f"Parameter '{key}' already exists in static URL '{static_url}' " + f"with value(s) {existing_params[key]}, overwriting with '{value}'" + ) existing_params[key] = [str(value)] # Rebuild the query string