NeoAnd/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2025-07-29 11:56:25 -06:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

Validate min & max VID values

Browse Source
This commit is contained in:
Jeremy Stretch 2024-11-20 14:27:33 -05:00
parent d1db3807aa
commit c5d87152a5
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
netbox/ipam/models/vlans.py
View File

@ -97,20 +97,26 @@ class VLANGroup(OrganizationalModel):
raise ValidationError(_("Cannot set scope_id without scope_type.")) raise ValidationError(_("Cannot set scope_id without scope_type."))
# Validate VID ranges # Validate VID ranges
if self.vid_ranges and check_ranges_overlap(self.vid_ranges):
raise ValidationError({'vid_ranges': _("Ranges cannot overlap.")})
# Validate max VID
for vid_range in self.vid_ranges: for vid_range in self.vid_ranges:
if vid_range.lower > VLAN_VID_MAX or vid_range.upper > VLAN_VID_MAX: if vid_range.lower < VLAN_VID_MIN:
raise ValidationError({'vid_ranges': _("Child vid cannot exceed {value}").format(value=VLAN_VID_MAX)}) raise ValidationError({
'vid_ranges': _("Starting VLAN ID in range cannot be less than {value}").format(value=VLAN_VID_MIN)
})
if vid_range.upper > VLAN_VID_MAX:
raise ValidationError({
'vid_ranges': _("Ending VLAN ID in range cannot exceed {value}").format(value=VLAN_VID_MAX)
})
if vid_range.lower > vid_range.upper: if vid_range.lower > vid_range.upper:
raise ValidationError({ raise ValidationError({
'vid_ranges': _( 'vid_ranges': _(
"Maximum child VID must be greater than or equal to minimum child VID ({value})" "Ending VLAN ID in range must be greater than or equal to the starting VLAN ID ({value})"
).format(value=vid_range) ).format(value=vid_range)
}) })
# Check for overlapping VID ranges
if self.vid_ranges and check_ranges_overlap(self.vid_ranges):
raise ValidationError({'vid_ranges': _("Ranges cannot overlap.")})
def save(self, *args, **kwargs): def save(self, *args, **kwargs):
self._total_vlan_ids = 0 self._total_vlan_ids = 0
for vid_range in self.vid_ranges: for vid_range in self.vid_ranges: