From c0a5de09a7511de85ece2ab53f258daf46c7ffcc Mon Sep 17 00:00:00 2001
From: Arthur <worldnomad@gmail.com>
Date: Thu, 8 Feb 2024 14:06:32 -0800
Subject: [PATCH] 14438 check valid script for views

---
 netbox/templates/extras/script/base.html |  4 ++--
 netbox/templates/extras/script/jobs.html | 13 +++++++++++++
 netbox/templates/extras/script_list.html |  7 ++++++-
 3 files changed, 21 insertions(+), 3 deletions(-)

diff --git a/netbox/templates/extras/script/base.html b/netbox/templates/extras/script/base.html
index 429db590e..501daa752 100644
--- a/netbox/templates/extras/script/base.html
+++ b/netbox/templates/extras/script/base.html
@@ -26,10 +26,10 @@
 {% block tabs %}
   <ul class="nav nav-tabs">
     <li class="nav-item" role="presentation">
-      <a class="nav-link{% if not tab %} active{% endif %}" href="{% url 'extras:script' script.id %}">{% trans "Script" %}</a>
+      <a class="nav-link{% if not tab %} active{% endif %}{% if not script.is_valid %} disabled{% endif %}" href="{% url 'extras:script' script.id %}">{% trans "Script" %}</a>
     </li>
     <li class="nav-item" role="presentation">
-      <a class="nav-link{% if tab == 'source' %} active{% endif %}" href="{% url 'extras:script_source' script.id %}">{% trans "Source" %}</a>
+      <a class="nav-link{% if tab == 'source' %} active{% endif %}{% if not script.is_valid %} disabled{% endif %}" href="{% url 'extras:script_source' script.id %}">{% trans "Source" %}</a>
     </li>
     <li class="nav-item" role="presentation">
       <a class="nav-link{% if tab == 'jobs' %} active{% endif %}" href="{% url 'extras:script_jobs' script.id %}">
diff --git a/netbox/templates/extras/script/jobs.html b/netbox/templates/extras/script/jobs.html
index c550e5de7..b256201fb 100644
--- a/netbox/templates/extras/script/jobs.html
+++ b/netbox/templates/extras/script/jobs.html
@@ -1,11 +1,24 @@
 {% extends 'extras/script/base.html' %}
 {% load render_table from django_tables2 %}
+{% load i18n %}
 
 {% block content %}
   <div class="row mb-3">
     <div class="col col-md-12">
       <div class="card">
         <div class="card-body table-responsive">
+
+          {% if not script.is_valid %}
+            <div class="alert alert-warning" role="alert">
+              <div class="d-flex justify-content-between">
+                <div>
+                  <i class="mdi mdi-alert"></i>
+                  {% trans "Script no longer exists in the source file." %}
+                </div>
+              </div>
+            </div>
+          {% endif %}
+
           {% render_table table 'inc/table.html' %}
           {% include 'inc/paginator.html' with paginator=table.paginator page=table.page %}
         </div>
diff --git a/netbox/templates/extras/script_list.html b/netbox/templates/extras/script_list.html
index 719ff60cb..f06ad9164 100644
--- a/netbox/templates/extras/script_list.html
+++ b/netbox/templates/extras/script_list.html
@@ -48,7 +48,12 @@
               {% with last_job=script.get_latest_jobs|get_key:script.name %}
                 <tr>
                   <td>
-                    <a href="{% url 'extras:script' script.pk %}" id="{{ script.module }}.{{ script.class_name }}">{{ script.name }}</a>
+                    {% if script.is_valid %}
+                      <a href="{% url 'extras:script' script.pk %}" id="{{ script.module }}.{{ script.class_name }}">{{ script.name }}</a>
+                    {% else %}
+                      <a href="{% url 'extras:script_jobs' script.pk %}" id="{{ script.module }}.{{ script.class_name }}">{{ script.name }}</a>
+                      <i class="mdi mdi-alert"></i>
+                    {% endif %}
                   </td>
                   <td>{{ script.description|markdown|placeholder }}</td>
                   {% if last_job %}