From be3d55a032b8710ac558de6eb995ea179e86d9c7 Mon Sep 17 00:00:00 2001 From: Jason Novinger Date: Mon, 7 Apr 2025 15:35:39 -0500 Subject: [PATCH] Address PR feedback, add ServiceFilterSet test for fhrpgroup --- netbox/ipam/tests/test_filtersets.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/netbox/ipam/tests/test_filtersets.py b/netbox/ipam/tests/test_filtersets.py index 3d60a9bd7..8779741df 100644 --- a/netbox/ipam/tests/test_filtersets.py +++ b/netbox/ipam/tests/test_filtersets.py @@ -2329,6 +2329,11 @@ class ServiceTestCase(TestCase, ChangeLoggedFilterSetTests): VirtualMachine(name='Virtual Machine 3', cluster=cluster), ) VirtualMachine.objects.bulk_create(virtual_machines) + fhrp_group = FHRPGroup.objects.create( + name='telnet', + protocol=FHRPGroupProtocolChoices.PROTOCOL_CARP, + group_id=101, + ) services = ( Service( @@ -2369,6 +2374,12 @@ class ServiceTestCase(TestCase, ChangeLoggedFilterSetTests): protocol=ServiceProtocolChoices.PROTOCOL_UDP, ports=[2003], ), + Service( + parent=fhrp_group, + name='Service 7', + protocol=ServiceProtocolChoices.PROTOCOL_UDP, + ports=[2004], + ), ) Service.objects.bulk_create(services) services[0].ipaddresses.add(ip_addresses[0]) @@ -2409,6 +2420,13 @@ class ServiceTestCase(TestCase, ChangeLoggedFilterSetTests): params = {'virtual_machine': [vms[0].name, vms[1].name]} self.assertEqual(self.filterset(params, self.queryset).qs.count(), 2) + def test_fhrp_group(self): + fhrp_group = FHRPGroup.objects.get() + params = {'fhrpgroup_id': [fhrp_group.pk]} + self.assertEqual(self.filterset(params, self.queryset).qs.count(), 1) + params = {'fhrpgroup': [fhrp_group.name]} + self.assertEqual(self.filterset(params, self.queryset).qs.count(), 1) + def test_ip_address(self): ips = IPAddress.objects.all()[:2] params = {'ip_address_id': [ips[0].pk, ips[1].pk]}