From bdecf7a3e31351c7a1ce0aad6c96fec42a8dbc70 Mon Sep 17 00:00:00 2001 From: Jeremy Stretch Date: Thu, 1 Mar 2018 14:40:39 -0500 Subject: [PATCH] Fixes #1936: Trigger validation error when attempting to create a virtual chassis without specifying member positions --- netbox/dcim/forms.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/netbox/dcim/forms.py b/netbox/dcim/forms.py index 593ffa6c0..e71f44389 100644 --- a/netbox/dcim/forms.py +++ b/netbox/dcim/forms.py @@ -2291,11 +2291,12 @@ class BaseVCMemberFormSet(forms.BaseModelFormSet): # Check for duplicate VC position values vc_position_list = [] for form in self.forms: - vc_position = form.cleaned_data['vc_position'] - if vc_position in vc_position_list: - error_msg = 'A virtual chassis member already exists in position {}.'.format(vc_position) - form.add_error('vc_position', error_msg) - vc_position_list.append(vc_position) + vc_position = form.cleaned_data.get('vc_position') + if vc_position: + if vc_position in vc_position_list: + error_msg = 'A virtual chassis member already exists in position {}.'.format(vc_position) + form.add_error('vc_position', error_msg) + vc_position_list.append(vc_position) class DeviceVCMembershipForm(forms.ModelForm):