From bbf8da2f1c3b393b819eccb23030d5002040c37c Mon Sep 17 00:00:00 2001 From: Jeremy Stretch Date: Tue, 29 Jul 2025 14:08:30 -0400 Subject: [PATCH] Clean up ObjectImageAttachmentsView --- netbox/netbox/views/generic/feature_views.py | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/netbox/netbox/views/generic/feature_views.py b/netbox/netbox/views/generic/feature_views.py index efa45541f..338ed0628 100644 --- a/netbox/netbox/views/generic/feature_views.py +++ b/netbox/netbox/views/generic/feature_views.py @@ -87,14 +87,7 @@ class ObjectChangeLogView(ConditionalLoginRequiredMixin, View): class ObjectImageAttachmentsView(ConditionalLoginRequiredMixin, View): """ - Render a list of all Job assigned to an object. For example: - - path( - 'data-sources//jobs/', - ObjectJobsView.as_view(), - name='datasource_jobs', - kwargs={'model': DataSource} - ) + Render all images attached to the object as linked thumbnails. Attributes: base_template: The name of the template to extend. If not provided, "{app}/{model}.html" will be used. @@ -107,12 +100,8 @@ class ObjectImageAttachmentsView(ConditionalLoginRequiredMixin, View): weight=6000 ) - def get_object(self, request, **kwargs): - return get_object_or_404(self.model.objects.restrict(request.user, 'view'), **kwargs) - def get(self, request, model, **kwargs): - self.model = model - obj = self.get_object(request, **kwargs) + obj = get_object_or_404(model.objects.restrict(request.user, 'view'), **kwargs) image_attachments = ImageAttachment.objects.filter( object_type=ContentType.objects.get_for_model(obj), object_id=obj.pk,